Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qthread taskpolicy initialization bug. #92

Closed
kyungjoo-kim opened this issue Sep 21, 2015 · 1 comment
Closed

Qthread taskpolicy initialization bug. #92

kyungjoo-kim opened this issue Sep 21, 2015 · 1 comment
Assignees
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)

Comments

@kyungjoo-kim
Copy link
Contributor

There are a couple of typos in Qthread task policy constructor. I fixed and submit a pull request and somehow this commit is appended to my previous pull request (team barrier) which is not resolved yet. If some one can make a quick fix for this, I appreciate for it.

core/src/Qthread/Kokkos_Qthread_TaskPolicy.hpp
@@ -490,7 +490,7 @@ class TaskPolicy< Kokkos::Qthread >
KOKKOS_INLINE_FUNCTION
TaskPolicy( const TaskPolicy & rhs )
: m_default_dependence_capacity( rhs.m_default_dependence_capacity )

  • , m_team_size( m_team_size )
  • , m_team_size( rhs.m_team_size )
    , m_active_count_root(0)
    , m_active_count( rhs.m_active_count )
    {}
    @@ -499,7 +499,7 @@ class TaskPolicy< Kokkos::Qthread >
    TaskPolicy( const TaskPolicy & rhs
    , const unsigned arg_default_dependence_capacity )
    : m_default_dependence_capacity( arg_default_dependence_capacity )
  • , m_team_size( m_team_size )
  • , m_team_size( rhs.m_team_size )
    , m_active_count_root(0)
    , m_active_count( rhs.m_active_count )
    {}
@hcedwar hcedwar added Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos) bug - fix pushed for public testing labels Sep 22, 2015
@crtrott
Copy link
Member

crtrott commented Oct 28, 2015

Pushed to master

@crtrott crtrott closed this as completed Oct 28, 2015
@hcedwar hcedwar added this to Backlog in On-node Task DAG Apr 19, 2017
@hcedwar hcedwar moved this from Feature Backlog to Done in On-node Task DAG Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken / incorrect code; it could be Kokkos' responsibility, or others’ (e.g., Trilinos)
Projects
No open projects
Development

No branches or pull requests

3 participants