Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers should be reworked #28

Closed
rarog opened this issue Mar 2, 2021 · 3 comments
Closed

Headers should be reworked #28

rarog opened this issue Mar 2, 2021 · 3 comments
Assignees
@kokspflanze

Comments

@rarog
Copy link

rarog commented Mar 2, 2021

The headers are a mix of BjyAuthorize Module (https://github.com/bjyoungblood/BjyAuthorize) and in part even Zend Framework (http://framework.zend.com/) like in UnauthorizedStrategyServiceFactoryTest.php - those should either be updated or removed.
Also they mention New BSD license while the project is under MIT license.
@kokspflanze
Copy link
Owner

sry, total missed your issue=(

i will add it on my todo list

@kokspflanze kokspflanze self-assigned this Apr 20, 2021
@kokspflanze
Copy link
Owner

@rarog PR created, hope its fine for you =)

@rarog
Copy link
Author

rarog commented Apr 26, 2021

@rarog PR created, hope its fine for you =)

The PR looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kokspflanze kokspflanze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kokspflanze @rarog