-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for jest.config.js
?
#10
Comments
This is a pretty common case and worth supporting 👍 |
@Koleok any update on this? |
@SimplyComplexable doesn't look any new PR was closed recently. |
I would love this feature. |
Well its cool to see that someone is using this 😅 I will try to get this done in the PM hours this week, I haven't used it in my daily work for a few years so it had just left my mental inbox so to speak :) |
I was able to find some time for this in the past few days, turns out its a little bit tricky to re-write a module.exports = {
// config
} It may be something like: const cleverConfigLogicBasedOnEnv = {
// ...
}
module.exports = {
...cleverConfigLogicBasedOnEnv,
// rest of config
} Certainly it can be done, it will just take some regexs and logic that will have to evolve over time as edge cases come up. With this in mind, I think the first pass will just support As a workaround until then, you could make a file called something like {
"coverageThreshold": {
"global": {
"lines": 86.67,
"statements": 74.29,
"functions": 10,
"branches": 50
}
}
} jest.config.js const coverageConfig = require('./jest.coverageConfig.json')
module.exports = {
...coverageConfig,
// rest of your config
} then just make sure that you are running the command like jest-coverage-ratchet --configPath ./jest.coverageConfig.json |
Hi @Koleok ! Just wanted to note next
thats true. different setups are possible. However, in readme you already do some assumptions
I would ask you to make one more. BTW thanks for great lib |
@ZuBB Fair enough 👌 , lets give it a try with that assumption, seems there are few enough users of this lib that its not a crazy experiment to assume a certain format of jest.config.js, I'll push up the new version over the next few days with that packed in 👍 |
I found a workaround for this using the current version;
{
"scripts": {
"test:coverage": "jest-coverage-ratchet",
}
}
const jestConfig = require('./package.json').jest;
module.exports = {
...jestConfig,
} |
There is a new package based on |
This works great, but I use
jest.config.js
instead of using thepackage.json
and when running the ratchet, it appends the new thresholds intopackage.json
.I tried
jest-coverage-ratchet --config-path ./jest.config.js
with no success. Even loggedconsole.log(configPath)
here https://github.com/Koleok/jest-coverage-ratchet/blob/master/src/index.js#L19. It did show the path tojest.config.js
but still bumped the package.jsonThe text was updated successfully, but these errors were encountered: