Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current published version on npm, v2.2.0 still relies on nx 15 #37

Closed
thomasburguiere opened this issue May 31, 2023 · 3 comments
Closed

Comments

@thomasburguiere
Copy link

thomasburguiere commented May 31, 2023

It seems that v2.2.0 still relies on nx 15.

e.g. in node_modules/@koliveira15/nx-sonarqube/src/executors/scan/executor.js we can see that the code still requires @nrwl/devkit (nx <16 style) instead of @nx/devkit

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
const tslib_1 = require("tslib");
const devkit_1 = require("@nrwl/devkit"); // <----------- 
const utils_1 = require("./utils/utils");

This prevents any project (or at least ours :D) that uses nx 16 to use this dependency.

It seems the issue has been solved by this commit a few days ago, whereas the latest publish to npm is roughly one month old. I assume therefore that just publishing to npm would solve the issue for dependant projects.

Thank you very much, feel free to write me if you need more info, or if I can support you in any way :)

@koliveira15
Copy link
Owner

@thomasburguiere thanks for reaching out. I am still figuring out a better way to publish and release with a workflow. Until then its pretty manual so apologies for any inconvenience!

Try using version 3.0.0 and let me know how it goes. Although, I thought as a part of the nx 16 upgrade, they would still support the old @nrwl/ namespace; maybe I am wrong.

@thomasburguiere
Copy link
Author

@thomasburguiere thanks for reaching out. I am still figuring out a better way to publish and release with a workflow. Until then its pretty manual so apologies for any inconvenience!

Try using version 3.0.0 and let me know how it goes. Although, I thought as a part of the nx 16 upgrade, they would still support the old @nrwl/ namespace; maybe I am wrong.

Hi @koliveira15 thanks a lot for the update, we will try immediately with v3.0.0 and let you know the outcome 🙂

@thomasburguiere
Copy link
Author

Hello @koliveira15 FYI, version 3.0.0 works perfectly.

Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants