Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hantera ui för saknade datum i aviseringar #124

Merged
merged 8 commits into from Feb 15, 2021

Conversation

believer
Copy link
Contributor

@believer believer commented Feb 15, 2021

Den här PRn gömmer datumet om det saknas i en avisering. Den gör att vi inte får det trasiga UI:t med tomma parenteser i #99 men löser inte den underliggande buggen att datumet saknas.

Jag har också lagt till de första testerna och setup för dem i appen. Testerna körs i jest och använder @testing-library/react-native.

@believer believer self-assigned this Feb 15, 2021
@vercel
Copy link

vercel bot commented Feb 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/skolplattformen/skolplattformen/ow9hs88sh
✅ Preview: Failed

[Deployment for 76d0356 canceled]

@believer believer changed the title fix: hantera saknade datum i aviseringar fix: hantera ui för saknade datum i aviseringar Feb 15, 2021
@believer believer merged commit 82c2379 into main Feb 15, 2021
@believer believer deleted the missing-notification-date branch February 15, 2021 11:11
github-actions bot pushed a commit that referenced this pull request Feb 21, 2021
# 1.0.0 (2021-02-21)

### Bug Fixes

* 🐛 add missing android release keystore ([75088a2](75088a2))
* 🐛 fix state handling on login screen ([a40f596](a40f596)), closes [#82](#82)
* 🐛 Fixed links when navigating other url:s ([53a9425](53a9425))
* 🐛 Fixed merge induced bug ([758738d](758738d))
* 🐛 Fixed so calendar doesn't bork if items don't load ([9b92941](9b92941))
* 🐛 handle close of ModalWebView for Android ([f250bcf](f250bcf))
* 🐛 Imported all code onto fresh RN install ([0f15f83](0f15f83))
* 🐛 Imported all code onto fresh RN install ([#40](#40)) ([f195e37](f195e37))
* 🐛 Länk till issues ([f3f3051](f3f3051))
* 🐛 Nyheter uppdateras ([eff2ada](eff2ada))
* 🐛 Nyheter uppdateras ([#114](#114)) ([bc56c73](bc56c73))
* 🐛 Pnr skickas efter omstart ([0aa68e8](0aa68e8))
* 🐛 properly load the SSN from the cache ([1051062](1051062)), closes [#82](#82)
* 🐛 remove applicationSuffix for Android debug variant ([52370d9](52370d9)), closes [#130](#130)
* 🐛 Removed lerna workspaces ([823818b](823818b))
* 🐛 Rensade länkar ([f4b9538](f4b9538))
* 🐛 Spelling ([343a98e](343a98e))
* 🐛 Time to read testimonials ([4518ae7](4518ae7))
* 🐛 Tog bort omladdning ([723a9df](723a9df))
* 🐛 Updated api dependencies ([#71](#71)) ([82cbb09](82cbb09))
* 🐛 Validerar cacheat pnr vid start ([06ff0c7](06ff0c7))
* använd statusfält med mörkt innehåll ([#122](#122)) ([b3f88c5](b3f88c5))
* broken title ([37e5750](37e5750))
* check validity of social security number ([582f5de](582f5de))
* contact menu closing on false clicks ([c758370](c758370))
* direktlänkning från knapparna i barnlistan ([491f321](491f321))
* display image of woman if user's socialSecurityNumber is female ([027233f](027233f))
* Enable Google Play Button ([4058428](4058428))
* göm ogiltiga datum i nyheter ([#152](#152)) ([bac38a2](bac38a2))
* handle dates and clicks on calendar items ([#64](#64)) ([df63a6b](df63a6b))
* handle line breaks in tab navigation ([#58](#58)) ([2f6c07a](2f6c07a))
* handle missing social security number ([c596b6c](c596b6c))
* hantera bilder med absolut url i markdown ([#156](#156)) ([e211439](e211439))
* hantera lång namn i barnlistan ([aef694c](aef694c))
* hantera ui för saknade datum i aviseringar ([#124](#124)) ([82c2379](82c2379))
* hide contact option if not available ([273f059](273f059))
* ikon och rubrik på Android appen ([8218965](8218965))
* looked broken when no new event ([#157](#157)) ([a191b45](a191b45))
* scroll i barnlistan och flytta frånvaroknapp ([#167](#167)) ([5a34b7a](5a34b7a))
* **android:** uppdatera färg på statusbar ([#150](#150)) ([b4860e0](b4860e0))
* login screen issues ([#69](#69)) ([ec6a4e0](ec6a4e0))
* removed texts saying the app isnt released and added section for how to report bugs ([#112](#112)) ([61b5189](61b5189))
* scroll overflow on child screens ([#65](#65)) ([a05e3c4](a05e3c4))
* uppdatera testimonial med rätt text ([#137](#137)) ([be228d1](be228d1))
* use nextjs link for integrity policy ([fce2c26](fce2c26))

### Features

* 🎸 Added privacy policy and changed price to 12 ([34b1a3c](34b1a3c))
* 🎸 Dra och ladda om ([5fb5587](5fb5587))
* 🎸 Encrypted cookie ([3419eda](3419eda))
* 🎸 Ingress under bild ([b3f1d57](b3f1d57))
* 🎸 Ladda alla nyheter ([8b913c6](8b913c6))
* 🎸 Links i markdown ([#86](#86)) ([7b165af](7b165af)), closes [#73](#73)
* 🎸 Login works with 201212121212 ([f57212e](f57212e))
* 🎸 Notifications viewable ([1a80f89](1a80f89))
* 🎸 Notifications viewable ([e6335ec](e6335ec))
* 🎸 Ombyggd nyhetsbrevshantering ([#111](#111)) ([2b8133d](2b8133d))
* 🎸 På sajten kan vi i alla fall köra analytics 😄 ([#79](#79)) ([7973285](7973285))
* 🎸 Readable news and updated navigation ([5835268](5835268))
* 🎸 Readable news and updated navigation ([79b80a1](79b80a1))
* 🎸 Removed download from head, added buttons to banner ([#42](#42)) ([1e45d28](1e45d28))
* 🎸 Updated API. Now with fake news images ([0367f60](0367f60))
* 🎸 Updated API. Now with fake news images ([5ef9ca1](5ef9ca1))
* 🎸 Using new fullImageUrl and cookie features for news img ([3fb3d89](3fb3d89))
* add app store link ([#74](#74)) ([5e6e91d](5e6e91d))
* add email on site ([#70](#70)) ([27229cc](27229cc))
* add Open Graph title, image and description ([524a118](524a118))
* add Q&A page ([0b816d9](0b816d9))
* added npm lib and implemented login and load children ([c2ab194](c2ab194))
* Datum på nyheter ([#110](#110)) ([cea1080](cea1080))
* Flyttade tabbarna längst ner ([#145](#145)) ([6c1ceae](6c1ceae))
* frånvaroanmälan ([#144](#144)) ([090a59e](090a59e))
* lägg till empty state för barnlistan ([#126](#126)) ([0cb24fe](0cb24fe))
* optimise images with next/image  ([#54](#54)) ([fbbf6fe](fbbf6fe)), closes [#29](#29)
* upgrade to next@10 to be able to use next/image ([082ea67](082ea67))

### BREAKING CHANGES

* 🧨 JWT is now delivered as JSON ({ token })
github-actions bot pushed a commit that referenced this pull request Oct 3, 2021
# [2.0.0](v1.48.0...v2.0.0) (2021-10-03)

### Bug Fixes

* 🐛 add 2 to xsrf header and use nav controller script again ([d1a4877](d1a4877))
* 🐛 add missing headers for fetching children ([68c99cb](68c99cb))
* 🐛 Add personal identity number to test user ([f977143](f977143))
* 🐛 added "Rast" to misc words in sv,en,pl translations ([#11](#11)) ([4da06bb](4da06bb))
* 🐛 Added build step ([#38](#38)) ([db0faf2](db0faf2))
* 🐛 Added isAuthenticated to test user ([#119](#119)) ([766f4ff](766f4ff))
* 🐛 Added luxon to fix getSchedule ([#13](#13)) ([fe1729c](fe1729c))
* 🐛 Added missing types ([3d59035](3d59035))
* 🐛 Adjusted cookie handling ([#79](#79)) ([16020a3](16020a3))
* 🐛 Autopublish (I hope) ([#37](#37)) ([ed8f8a7](ed8f8a7))
* 🐛 Build before publish ([e934950](e934950))
* 🐛 Cache is no longer called in fake mode ([#3](#3)) ([f89f143](f89f143))
* 🐛 Changed build settings ([7a7c2a1](7a7c2a1))
* 🐛 Cleanup on logout ([#6](#6)) ([644cbcd](644cbcd))
* 🐛 Correct format of fakeData.js ([c2adf00](c2adf00))
* 🐛 Fake data included through ts ([663be5c](663be5c))
* 🐛 Fix för login block 24mars ([7667a5e](7667a5e))
* 🐛 fix latest security "fix" ([d795458](d795458))
* 🐛 fix the previous fix with a fixed json ([eefd791](eefd791))
* 🐛 Fixa markdownkonvertering av hårresande html ([#120](#120)) ([4991f91](4991f91))
* 🐛 Fixar links med mellanslag ([#63](#63)) ([3edbf8c](3edbf8c))
* 🐛 Fixar senaste blocken ([#81](#81)) ([1ccdc9f](1ccdc9f))
* 🐛 Fixed fake data for notifications ([#40](#40)) ([b8621b9](b8621b9))
* 🐛 Fixed parsing bug for classmates ([5f07259](5f07259))
* 🐛 Fixes base64 iterations ([52d7341](52d7341))
* 🐛 Fixes configuration fetch ([7bf8f1c](7bf8f1c))
* 🐛 Fixes more sabotage from sthlm stad ([ab62ab6](ab62ab6))
* 🐛 Fixes schedule ([fb65a33](fb65a33))
* 🐛 Flytta mellanslag utanför taggarna ([#124](#124)) ([79e2a75](79e2a75))
* 🐛 Förbättrad parsning av nyhetsbrev ([#125](#125)) ([82fa2dc](82fa2dc))
* 🐛 Force release ([#115](#115)) ([5c170dc](5c170dc))
* 🐛 Get all notifications. Add modified date to notifications ([#150](#150)) ([4a0841a](4a0841a))
* 🐛 hämta API key från server ([9bde441](9bde441))
* 🐛 implemented XSRF token support ([1ecfdaf](1ecfdaf))
* 🐛 Moved topologykey to config, also added getHeader() ([2823547](2823547))
* 🐛 News item details now gets parsed ([#55](#55)) ([50ce985](50ce985))
* 🐛 Ny version av curriculum ([#148](#148)) ([e54ed25](e54ed25))
* 🐛 Parse old aspnet dates instead of unreliable format strings ([#108](#108)) ([3c33c75](3c33c75)), closes [#105](#105)
* 🐛 Parsning ([83ec383](83ec383))
* 🐛 read xsrf token from script for createItem call ([1deb424](1deb424))
* 🐛 Reload anropar bara apiet om den inte redan laddar ([#9](#9)) ([c329283](c329283))
* 🐛 reload inaktivt i fejk ([#10](#10)) ([9fa63e8](9fa63e8))
* 🐛 Removed dynamic require ([#8](#8)) ([a3421b8](a3421b8))
* 🐛 Removed superfluous property in en.json ([#5](#5)) ([b6137ab](b6137ab))
* 🐛 rensa upp getChildren anropet och ny release ([2336861](2336861))
* 🐛 Repaired login ([#11](#11)) ([83a4737](83a4737))
* 🐛 Replaced named capture group for compatibility reasons ([#112](#112)) ([66b23fa](66b23fa))
* 🐛 Replaces non breaking space with simple space ([#57](#57)) ([58d5676](58d5676))
* 🐛 Return a empty array if backend returns a specific error ([1e944ad](1e944ad))
* 🐛 semikolonviolation! ([46c6260](46c6260))
* 🐛 Silly stockholm stad protection ([cd19abd](cd19abd))
* 🐛 Tog bort radbrytning i bold ([#66](#66)) ([ca0117c](ca0117c))
* 🐛 Trims tag content to fix some markdown issues ([#56](#56)) ([f9dc391](f9dc391))
* 🐛 URLSearchParams compatible with both node and RN ([#111](#111)) ([fd919a0](fd919a0))
* 🐛 use childcontroller script for XSRF header to CreateItem ([2796875](2796875))
* 🐛 Working notification url:s ([#41](#41)) ([3a808f9](3a808f9))
* add date handler ([a3e0eba](a3e0eba))
* correct fake data dates ([d88bfcf](d88bfcf))
* handle iso date strings ([ca0a3e4](ca0a3e4))
* handle long dates with time ([3ba96fe](3ba96fe))
* handle missing spaces in intro after certain characters ([#99](#99)) ([2926de3](2926de3))
* links ([#64](#64)) ([905b893](905b893))
* parse calendar dates as utc before iso ([#100](#100)) ([73f6d8b](73f6d8b))
* parse intro without positive lookbehind regex ([#102](#102)) ([f8b3df2](f8b3df2))
* Translations update from Weblate ([#16](#16)) ([94a3883](94a3883))
* use date constructor instead of luxon ([74ea878](74ea878))
* use parseDate for all date handling ([6cd92ac](6cd92ac))

### Features

* 🎸 Added .author and .imageAltText on NewsItem ([#42](#42)) ([6e84a63](6e84a63))
* 🎸 Added getter for logged in personal number ([#39](#39)) ([a860d12](a860d12))
* 🎸 Added language support ([#121](#121)) ([9dcdf78](9dcdf78))
* 🎸 Alla nyhetsbrev ([#67](#67)) ([f3f658f](f3f658f))
* 🎸 API call retries and support for error reporting ([#5](#5)) ([9ed5df2](9ed5df2))
* 🎸 Build, tag and release ([b71adc5](b71adc5))
* 🎸 cache busting ([5ce4ddd](5ce4ddd))
* 🎸 Cache prefixas med personnummer ([#8](#8)) ([fc146ea](fc146ea))
* 🎸 Classmates ([#14](#14)) ([a6ce6ea](a6ce6ea)), closes [#7](#7)
* 🎸 Code cleanup, refactoring, linting and tests ([d0a0314](d0a0314))
* 🎸 Curriculum as peer dependency ([#122](#122)) ([e24a9b3](e24a9b3))
* 🎸 Exporting all types in index ([#45](#45)) ([8351ef2](8351ef2))
* 🎸 Exporting LoginStatusChecker interface ([#46](#46)) ([20e18e5](20e18e5))
* 🎸 Fake mode for 121212121212, 201212121212 and 1212121212 ([#35](#35)) ([8d264b9](8d264b9))
* 🎸 Fakedata laggar 0.2-1 sekund ([#68](#68)) ([018d600](018d600))
* 🎸 Fallback language ([#7](#7)) ([e944468](e944468))
* 🎸 First implementation ([e5438b0](e5438b0))
* 🎸 First release ([d37f3db](d37f3db))
* 🎸 Forcing release ([d4151fa](d4151fa))
* 🎸 getSessionCookie and removed News object ([#24](#24)) ([91ba683](91ba683)), closes [#22](#22) [#23](#23)
* 🎸 getUser ([#19](#19)) ([39b62b7](39b62b7)), closes [#9](#9)
* 🎸 Hämta lektionsschema ([#110](#110)) ([c288449](c288449))
* 🎸 Image ([#21](#21)) ([2ad7523](2ad7523)), closes [#10](#10)
* 🎸 It now handles comments ([065e0e9](065e0e9))
* 🎸 Loads schedule ([#16](#16)) ([53d42de](53d42de)), closes [#13](#13) [#8](#8)
* 🎸 Made User properties optional for hook convenience ([#31](#31)) ([0e0e996](0e0e996))
* 🎸 Misc codes (Lunch, Prandium, MTID) ([59e350b](59e350b))
* 🎸 Multilang support for useTimetable ([#14](#14)) ([be6c9d1](be6c9d1))
* 🎸 Names from curriculum ([#116](#116)) ([504503f](504503f))
* 🎸 New properties on NewsItem and updated fake data ([#44](#44)) ([dea899b](dea899b))
* 🎸 News are sorted, desc, by modified date ([#147](#147)) ([a4b7b7f](a4b7b7f))
* 🎸 News images that do not require login ([#43](#43)) ([5daf186](5daf186))
* 🎸 Notifications ([#20](#20)) ([348e437](348e437)), closes [#11](#11)
* 🎸 Notifications sorted by modified, then created date ([#151](#151)) ([91f63e8](91f63e8))
* 🎸 Polish ([#9](#9)) ([18c8126](18c8126))
* 🎸 Possibly first working version ([0e4acba](0e4acba))
* 🎸 Remove all obsolete login obstacles ([#146](#146)) ([befb073](befb073))
* 🎸 Remove required personal number in route ([#118](#118)) ([c3b4b15](c3b4b15))
* 🎸 Removed getImage() and added .fullImageUrl to NewsItem ([#33](#33)) ([5c3929d](5c3929d))
* 🎸 Replaced Moment with Luxon ([#30](#30)) ([e41f0bf](e41f0bf))
* 🎸 Släpp sargen - nu kör vi ([#60](#60)) ([c5e9992](c5e9992))
* 🎸 Switched to Markdown Extra converter ([#58](#58)) ([3b7b067](3b7b067))
* 🎸 Timetables ([#12](#12)) ([2ae212d](2ae212d))
* 🎸 Updated curriculum and fake data with new codes ([#117](#117)) ([0a02ffa](0a02ffa))
* 🎸 useNewsDetails(child, news) ([5d4f751](5d4f751))
* add newsItemDetails ([1826b80](1826b80))
* call newsItemDetails to get details for a news item. Resolves [#28](#28) ([5dcc42e](5dcc42e))
* Improve menu ([#109](#109)) ([9c4fcb2](9c4fcb2))
* Ombyggd parsning av nyhetsbrev ([#65](#65)) ([a5dfb70](a5dfb70))
* update typings for ScheduleItem ([9c87535](9c87535))

* Rebuilt session handling and login (#78) ([c62dab9](c62dab9)), closes [#78](#78)

### BREAKING CHANGES

* 🧨 useTimetable now requires lang
* 🧨 getTimetable requires language
* 🧨 Child -> EtjanstChild

* feat: 🎸 Test data for skola24Children and timetable

* docs: ✏️ Updated instructions

Co-authored-by: Johan Öbrink <johan.obrink@gmail.com>
* This updates the `startDate` and `endDate` to be
potentially `undefined`
* 🧨 Major update of peer dependency embedded-api
* 🧨 Cookie and Session handling reworked
* 🧨 Nä... egentligen inte
* 🧨 api no longer exposes getImage()
* 🧨 Change to types (moment -> strings) and api.getSchedule (moment ->
luxon.DateTime)
* 🧨 Call signature of getNews changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant