Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hantera bilder med absolut url i markdown #156

Merged
merged 2 commits into from Feb 19, 2021
Merged

fix: hantera bilder med absolut url i markdown #156

merged 2 commits into from Feb 19, 2021

Conversation

kajetan-kazimierczak
Copy link
Contributor

The "src" of images in news was always prepended by the host name of skolplattformen, breaking images where the src was a complete url. This PR fixes the issue. Only when the src starts with "/" it's prepended, otherwise it's left as it is.

@vercel
Copy link

vercel bot commented Feb 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/skolplattformen/skolplattformen/qsss0hbta
✅ Preview: Canceled

Copy link
Contributor

@believer believer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix, thanks! Welcome as a contributor @kajetan-kazimierczak!

@believer believer changed the title Correctly show images with full URLs as src inside news articles fix: hantera bilder med absolut url i markdown Feb 19, 2021
@believer believer merged commit e211439 into kolplattformen:main Feb 19, 2021
github-actions bot pushed a commit that referenced this pull request Feb 21, 2021
# 1.0.0 (2021-02-21)

### Bug Fixes

* 🐛 add missing android release keystore ([75088a2](75088a2))
* 🐛 fix state handling on login screen ([a40f596](a40f596)), closes [#82](#82)
* 🐛 Fixed links when navigating other url:s ([53a9425](53a9425))
* 🐛 Fixed merge induced bug ([758738d](758738d))
* 🐛 Fixed so calendar doesn't bork if items don't load ([9b92941](9b92941))
* 🐛 handle close of ModalWebView for Android ([f250bcf](f250bcf))
* 🐛 Imported all code onto fresh RN install ([0f15f83](0f15f83))
* 🐛 Imported all code onto fresh RN install ([#40](#40)) ([f195e37](f195e37))
* 🐛 Länk till issues ([f3f3051](f3f3051))
* 🐛 Nyheter uppdateras ([eff2ada](eff2ada))
* 🐛 Nyheter uppdateras ([#114](#114)) ([bc56c73](bc56c73))
* 🐛 Pnr skickas efter omstart ([0aa68e8](0aa68e8))
* 🐛 properly load the SSN from the cache ([1051062](1051062)), closes [#82](#82)
* 🐛 remove applicationSuffix for Android debug variant ([52370d9](52370d9)), closes [#130](#130)
* 🐛 Removed lerna workspaces ([823818b](823818b))
* 🐛 Rensade länkar ([f4b9538](f4b9538))
* 🐛 Spelling ([343a98e](343a98e))
* 🐛 Time to read testimonials ([4518ae7](4518ae7))
* 🐛 Tog bort omladdning ([723a9df](723a9df))
* 🐛 Updated api dependencies ([#71](#71)) ([82cbb09](82cbb09))
* 🐛 Validerar cacheat pnr vid start ([06ff0c7](06ff0c7))
* använd statusfält med mörkt innehåll ([#122](#122)) ([b3f88c5](b3f88c5))
* broken title ([37e5750](37e5750))
* check validity of social security number ([582f5de](582f5de))
* contact menu closing on false clicks ([c758370](c758370))
* direktlänkning från knapparna i barnlistan ([491f321](491f321))
* display image of woman if user's socialSecurityNumber is female ([027233f](027233f))
* Enable Google Play Button ([4058428](4058428))
* göm ogiltiga datum i nyheter ([#152](#152)) ([bac38a2](bac38a2))
* handle dates and clicks on calendar items ([#64](#64)) ([df63a6b](df63a6b))
* handle line breaks in tab navigation ([#58](#58)) ([2f6c07a](2f6c07a))
* handle missing social security number ([c596b6c](c596b6c))
* hantera bilder med absolut url i markdown ([#156](#156)) ([e211439](e211439))
* hantera lång namn i barnlistan ([aef694c](aef694c))
* hantera ui för saknade datum i aviseringar ([#124](#124)) ([82c2379](82c2379))
* hide contact option if not available ([273f059](273f059))
* ikon och rubrik på Android appen ([8218965](8218965))
* looked broken when no new event ([#157](#157)) ([a191b45](a191b45))
* scroll i barnlistan och flytta frånvaroknapp ([#167](#167)) ([5a34b7a](5a34b7a))
* **android:** uppdatera färg på statusbar ([#150](#150)) ([b4860e0](b4860e0))
* login screen issues ([#69](#69)) ([ec6a4e0](ec6a4e0))
* removed texts saying the app isnt released and added section for how to report bugs ([#112](#112)) ([61b5189](61b5189))
* scroll overflow on child screens ([#65](#65)) ([a05e3c4](a05e3c4))
* uppdatera testimonial med rätt text ([#137](#137)) ([be228d1](be228d1))
* use nextjs link for integrity policy ([fce2c26](fce2c26))

### Features

* 🎸 Added privacy policy and changed price to 12 ([34b1a3c](34b1a3c))
* 🎸 Dra och ladda om ([5fb5587](5fb5587))
* 🎸 Encrypted cookie ([3419eda](3419eda))
* 🎸 Ingress under bild ([b3f1d57](b3f1d57))
* 🎸 Ladda alla nyheter ([8b913c6](8b913c6))
* 🎸 Links i markdown ([#86](#86)) ([7b165af](7b165af)), closes [#73](#73)
* 🎸 Login works with 201212121212 ([f57212e](f57212e))
* 🎸 Notifications viewable ([1a80f89](1a80f89))
* 🎸 Notifications viewable ([e6335ec](e6335ec))
* 🎸 Ombyggd nyhetsbrevshantering ([#111](#111)) ([2b8133d](2b8133d))
* 🎸 På sajten kan vi i alla fall köra analytics 😄 ([#79](#79)) ([7973285](7973285))
* 🎸 Readable news and updated navigation ([5835268](5835268))
* 🎸 Readable news and updated navigation ([79b80a1](79b80a1))
* 🎸 Removed download from head, added buttons to banner ([#42](#42)) ([1e45d28](1e45d28))
* 🎸 Updated API. Now with fake news images ([0367f60](0367f60))
* 🎸 Updated API. Now with fake news images ([5ef9ca1](5ef9ca1))
* 🎸 Using new fullImageUrl and cookie features for news img ([3fb3d89](3fb3d89))
* add app store link ([#74](#74)) ([5e6e91d](5e6e91d))
* add email on site ([#70](#70)) ([27229cc](27229cc))
* add Open Graph title, image and description ([524a118](524a118))
* add Q&A page ([0b816d9](0b816d9))
* added npm lib and implemented login and load children ([c2ab194](c2ab194))
* Datum på nyheter ([#110](#110)) ([cea1080](cea1080))
* Flyttade tabbarna längst ner ([#145](#145)) ([6c1ceae](6c1ceae))
* frånvaroanmälan ([#144](#144)) ([090a59e](090a59e))
* lägg till empty state för barnlistan ([#126](#126)) ([0cb24fe](0cb24fe))
* optimise images with next/image  ([#54](#54)) ([fbbf6fe](fbbf6fe)), closes [#29](#29)
* upgrade to next@10 to be able to use next/image ([082ea67](082ea67))

### BREAKING CHANGES

* 🧨 JWT is now delivered as JSON ({ token })
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants