Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing modules #4

Closed
Zerg00s opened this issue Nov 7, 2016 · 3 comments
Closed

Missing modules #4

Zerg00s opened this issue Nov 7, 2016 · 3 comments

Comments

@Zerg00s
Copy link

Zerg00s commented Nov 7, 2016

There were a few modules I had to manually install after running generator-sppp 1.5:
npm install request-promise --save
npm install node-sp-auth --save
npm install socket.io-client --save

@koltyakov
Copy link
Owner

Hi,

It's the dependencies from sp-live-reload and should be installed automatically.

Could you please describe the scenario, when these references were missed? Was it an update?

@Zerg00s
Copy link
Author

Zerg00s commented Nov 7, 2016

Maybe I did something wrong but these were the steps I've followed:

  • yo ( update generator-sppp)
  • yo (generate a new project from scratch in a new empty folder)
  • yeoman says that it will do "npm install" automatically and it does so.
  • when trying to use gulp tasks that rely on sp-live-reload, I get errors about these three modules being missing

@koltyakov
Copy link
Owner

Was not able to reproduce on a couple different workstations.
Is it still happening on your end?
It will be incorrect to include these dependencies in the package.
If you face such a behavior could you please provide some additional information:

  • node/npm/yo versions
  • zipped node_modules folder from early created project from scratch (or a complete project arch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants