Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table selection JS example bug #31

Closed
Snupas opened this issue Jan 31, 2020 · 1 comment
Closed

Table selection JS example bug #31

Snupas opened this issue Jan 31, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Snupas
Copy link

Snupas commented Jan 31, 2020

Currently, the onchange event handler conditional for the checkbox input is set to:

if (event.currentTarget.checked) { dispatch(ActionType.SelectRow, { rowKeyValue }); } else { dispatch(ActionType.SelectRow, { rowKeyValue }); }
https://stackblitz.com/edit/table-selection-js?file=Demo.js

Should be like in the TS example:

if (event.currentTarget.checked) { dispatch(ActionType.SelectRow, { rowKeyValue }); } else { dispatch(ActionType.DeselectRowData, { rowKeyValue }); }
https://stackblitz.com/edit/table-selection-ts?file=Demo.tsx

(Loving the component btw. Has just the right set amount of features built in to get going.)

@komarovalexander komarovalexander self-assigned this Jan 31, 2020
@komarovalexander
Copy link
Owner

komarovalexander commented Jan 31, 2020

Hi @Snupas
Thank you for your feedback, the issue has been fixed
https://stackblitz.com/edit/table-selection-js?file=Demo.js

@komarovalexander komarovalexander added the bug Something isn't working label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants