Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing toggle behavior #10

Closed
2 tasks done
Tracked by #7
juliandsg0222 opened this issue Jan 20, 2022 · 0 comments · Fixed by #14
Closed
2 tasks done
Tracked by #7

Implementing toggle behavior #10

juliandsg0222 opened this issue Jan 20, 2022 · 0 comments · Fixed by #14
Assignees
@juliandsg0222
Labels
👍 Feature New feature or request

Comments

@juliandsg0222
Copy link
Member

juliandsg0222 commented Jan 20, 2022 •
edited

ℹ️ This issue is part of the Epic #7

Context

For a toggle to be distinguished from a paragraph, the icon must be clickable:

  • implement a method that captures clicks on the icon
  • create a second svg element to the tool

Description

When a toggle is created must be have the following behavior with its icon:

  • right arrow in its initial state (the toggle is closed).
  • down arrow when clicked and the toggle was closed (the toggle is now open)
@juliandsg0222 juliandsg0222 added the 👍 Feature New feature or request label Jan 20, 2022
@juliandsg0222 juliandsg0222 self-assigned this Jan 20, 2022
@juliandsg0222 juliandsg0222 mentioned this issue Jan 20, 2022
Closed
21 tasks
@juliandsg0222 juliandsg0222 added ➡️ Next up Next thing to be tackled 📍 Work in progress Current work in progress 🔍 Review Code is being reviewed and removed ➡️ Next up Next thing to be tackled 📍 Work in progress Current work in progress labels Jan 20, 2022
@juliandsg0222 juliandsg0222 mentioned this issue Jan 21, 2022
Merged
@juliandsg0222 juliandsg0222 removed the 🔍 Review Code is being reviewed label Jan 21, 2022
@juliandsg0222 juliandsg0222 mentioned this issue Jan 24, 2022
Merged
@juliandsg0222 juliandsg0222 linked a pull request Mar 31, 2022 that will close this issue
10 - Add the toggle behavior #14
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliandsg0222 juliandsg0222

Labels
👍 Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

10 - Add the toggle behavior kommitters/editorjs-toggle-block
1 participant
@juliandsg0222