Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiline output is not supported #5

Open
matthiasg opened this issue Apr 16, 2015 · 4 comments
Open

multiline output is not supported #5

matthiasg opened this issue Apr 16, 2015 · 4 comments

Comments

@matthiasg
Copy link

added a pull-request for that #6

@amtdevops
Copy link

have you mreged it to master branch?

@matthiasg
Copy link
Author

@amtdevops not sure what you mean .. i did base my change on the master yes but that was 4 years ago :) Looks still current of course since the master did not change since then.

@dibishks
Copy link

dibishks commented May 7, 2019

@matthiasg but the code not working its still returns single barcode code when I provide 'multi: false'

While checking the master code I can see that 'qrcode' variable declared as string and loop breaks when it finds the first match. Can you fix this issue

https://github.com/komola/node-zxing/blob/master/lib/main.js#L30
https://github.com/komola/node-zxing/blob/master/lib/main.js#L39

@matthiasg
Copy link
Author

@dibishks I am not the maintainer of this project and have no access to it. The change is quite trivial as you identified already. Just check the code out and change it to return all codes detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants