-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing target choices when there is only one target #3
Comments
👍 was holding back since more are coming ... though for ocaml doubt there will be (didn't even anticipate we'll have that one on launch) |
Couldn't we add the logic of "If there's more than one, show up" instead of doing it on a per target basis? |
yeah, that's what i'll be doing ... |
There won't be another one for OCaml, you can just remove the All checkbox, but I think it's important to keep the "Cohttp" somewhere because it's important information. |
I think a design update is needed, I wanna be able to show the "library" info somewhere, link to source ... @jitachi |
Should still remove it for now because it's really weird. That OCaml uses a library needs to be apparent inside the code or embedded widget since people will be seeing it embedded in another website. A code comment at the top would be sufficient, just like we do with Unirest on mashape. |
@montanaflynn yeah, I think we're saying the same thing, I mean for inside the widget, not the site, be nice to give credit to the library source & even the contributing author for each target converter something along the lines of: Unirest support by @therebelrobot |
maybe for libraries the text would be: |
I was mostly replying to @SGrondin to make sure the library is mentioned inside the embedded widget. So in the top of his code he would put something like:
and we would do the same for Unirest and other non-native targets. |
ah, code comments, yes those are good. |
I'll add a comment. |
If there is only one implementation for a target then we shouldn't ask.
The text was updated successfully, but these errors were encountered: