Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing target choices when there is only one target #3

Closed
montanaflynn opened this issue Mar 11, 2015 · 12 comments
Closed

Showing target choices when there is only one target #3

montanaflynn opened this issue Mar 11, 2015 · 12 comments
Assignees

Comments

@montanaflynn
Copy link
Contributor

If there is only one implementation for a target then we shouldn't ask.

screen shot 2015-03-11 at 4 27 08 pm

@ahmadnassri
Copy link
Contributor

👍 was holding back since more are coming ... though for ocaml doubt there will be (didn't even anticipate we'll have that one on launch)

@montanaflynn
Copy link
Contributor Author

Couldn't we add the logic of "If there's more than one, show up" instead of doing it on a per target basis?

@ahmadnassri
Copy link
Contributor

yeah, that's what i'll be doing ...

@SGrondin
Copy link

There won't be another one for OCaml, you can just remove the All checkbox, but I think it's important to keep the "Cohttp" somewhere because it's important information.

@ahmadnassri
Copy link
Contributor

I think a design update is needed, I wanna be able to show the "library" info somewhere, link to source ... @jitachi

@montanaflynn
Copy link
Contributor Author

Should still remove it for now because it's really weird. That OCaml uses a library needs to be apparent inside the code or embedded widget since people will be seeing it embedded in another website. A code comment at the top would be sufficient, just like we do with Unirest on mashape.

@ahmadnassri
Copy link
Contributor

@montanaflynn yeah, I think we're saying the same thing, I mean for inside the widget, not the site, be nice to give credit to the library source & even the contributing author for each target converter

something along the lines of:

Unirest support by @therebelrobot

@ahmadnassri
Copy link
Contributor

something along those lines:

image

@ahmadnassri
Copy link
Contributor

maybe for libraries the text would be: COhttp support by ... since the language name is already obvious in the tab

@montanaflynn
Copy link
Contributor Author

I was mostly replying to @SGrondin to make sure the library is mentioned inside the embedded widget.

So in the top of his code he would put something like:

(* Requires https://github.com/mirage/ocaml-cohttp *)

and we would do the same for Unirest and other non-native targets.

@ahmadnassri
Copy link
Contributor

ah, code comments, yes those are good.

@SGrondin
Copy link

I'll add a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants