Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests failing #41

Closed
qwo opened this issue Feb 3, 2016 · 0 comments
Closed

tests failing #41

qwo opened this issue Feb 3, 2016 · 0 comments
Assignees

Comments

@qwo
Copy link
Contributor

qwo commented Feb 3, 2016

due to https://github.com/Mashape/mockbin/blob/master/src/middleware/negotiate-content.js#L31

a recommended style by standard is pretty: !!spaces, to typecast it to a boolean. Either ways readable but this will make eslint happy and get it back to passing tests.

standard: Use JavaScript Standard Style (https://github.com/feross/standard)
  /Users/stanleyzheng/null/mockbin/src/middleware/negotiate-content.js:35:31: Unnecessary use of boolean literals in conditional expression
  /Users/stanleyzheng/null/mockbin/src/middleware/negotiate-content.js:35:44: Extra semicolon.
npm ERR! Test failed.  See above for more details.

other work around is to specify rules and setup a .eslintrc for the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants