Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent error messages from DAO #55

Closed
subnetmarco opened this issue Mar 5, 2015 · 3 comments
Closed

Inconsistent error messages from DAO #55

subnetmarco opened this issue Mar 5, 2015 · 3 comments
Assignees
Labels

Comments

@subnetmarco
Copy link
Member

I expect DAO errors to be returned in the following form:

{
  database = true,
  message = "localhost could not be resolved (3: Host not found)"
}

But sometimes they show up in an inconsistent format, like:

{
  database = true,
  message = {
    database = true,
    message = "localhost could not be resolved (3: Host not found)"
  }
}

This specific example can be replicated by setting an invalid IP address/host in the Cassandra hosts property, starting the server and making a request.

@subnetmarco subnetmarco added this to the 0.0.1-beta2 milestone Mar 5, 2015
@thibaultcha
Copy link
Member

I really can't reproduce this. Here is an attempt:

local inspect = require "inspect"

local new_factory = CassandraFactory({ hosts = "helloworld",
                                       port = 45678,
                                       timeout = 1000,
                                       keyspace = configuration.cassandra.keyspace
})

local err = new_factory:prepare()
print(inspect(err))

local api_t = faker:fake_entity("api")
local api, err = new_factory.apis:insert(api_t)
print(inspect(err))

It's just doing as currently expected, failing on prepare and throwing an error on insert:

{
  database = true,
  message = "host not found"
}

But since main.lua exits on a prepare error, I really don't understand how this can happen. Please provide a test to reproduce.

@thibaultcha
Copy link
Member

Please try to reproduce against master.

@subnetmarco
Copy link
Member Author

I'm now getting

 [lua] init_by_lua:5: Startup error: host not found

Can't reproduce.

bungle added a commit that referenced this issue Sep 22, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Sep 27, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Sep 28, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Sep 30, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Oct 6, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Oct 7, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Oct 8, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Nov 6, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Dec 3, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Dec 10, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Dec 18, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Dec 22, 2020
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Jan 13, 2021
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Feb 2, 2021
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit that referenced this issue Jun 28, 2021
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
javierguerragiraldez pushed a commit that referenced this issue Sep 3, 2021
* fix(logging) encode try-list as json and no longer use new-line

New-line characters in the logging are impossible to parse
correctly so should be prevented.

fixes #52
gszr pushed a commit that referenced this issue Oct 26, 2021
Fixes #55

In all the Spans generated by kong:

* The `localEndpoint` is `{ serviceName = "kong" }` in all spans.

The `remoteEndpoint` has changed as follows:

* On the request (root) span, it remains as before:
  * `remoteEndpoint.ipv4/v6` and `remoteEndpoint.port` point to
    the consumer's forwarded ip and port

* On each balancer attempt span:
  * If a Kong Service was found when proxying, and that Service has a
    `name`, then `remoteEndpoint.serviceName` will be the Service Name.
  * `remoteEndpoint.ipv4/v6` and `remoteEndpoint.port` will point to
    the ip+port combination used on the span

* On the proxy span:
  * If a Kong Service was found when proxying, and that Service has a
    `name`, then `remoteEndpoint.serviceName` will be the Service Name.
  * `remoteEndpoint.ipv4/v6` and `remoteEndpoint.port` will point to
    the first successful combination of balancer attempts.
gszr pushed a commit that referenced this issue Oct 27, 2021
Fixes #55

In all the Spans generated by kong:

* The `localEndpoint` is `{ serviceName = "kong" }` in all spans.

The `remoteEndpoint` has changed as follows:

* On the request (root) span, it remains as before:
  * `remoteEndpoint.ipv4/v6` and `remoteEndpoint.port` point to
    the consumer's forwarded ip and port

* On each balancer attempt span:
  * If a Kong Service was found when proxying, and that Service has a
    `name`, then `remoteEndpoint.serviceName` will be the Service Name.
  * `remoteEndpoint.ipv4/v6` and `remoteEndpoint.port` will point to
    the ip+port combination used on the span

* On the proxy span:
  * If a Kong Service was found when proxying, and that Service has a
    `name`, then `remoteEndpoint.serviceName` will be the Service Name.
  * `remoteEndpoint.ipv4/v6` and `remoteEndpoint.port` will point to
    the first successful combination of balancer attempts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants