Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write GEP for specifying path segment match in HTTPRoute of gateway API #5839

Open
2 of 6 tasks
randmonkey opened this issue Apr 9, 2024 · 0 comments
Open
2 of 6 tasks
Assignees
Labels
area/CRD Changes in existing CRDs or introduction of new ones area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API priority/low
Milestone

Comments

@randmonkey
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

Currently HTTPRoute does not have a path match type of segment matching, neither does it have an "implementation specific" match. Also it does not allow custom path match type of in its CRD definition. With the current definition of HTTPRoute in gateway APIs, we have to specify path segment match as RegularExpression type of path match and use certain annotation and prefix of path. This does not satisfy the definition of RegularExpression match.
To specify path segment match in a more canonical way, we need to make upstream support a dedicated path match type for it.

Proposed Solution

  • Write a GEP for proposing a path match type of path segment match
  • When it is accepted, implement the definition and conformance tests for path segment match

Additional information

No response

Acceptance Criteria

  • The GEP of adding path match type for path segment match is accepted by upstream of gateway API
  • Implement the specification of the API and conformance tests
  • Implement path segment match in KIC based on the API definition and pass the tests
  • Update the docs to describe the usage and specification of path segment match
@randmonkey randmonkey added area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API area/CRD Changes in existing CRDs or introduction of new ones labels Apr 9, 2024
@mflendrich mflendrich added this to the KIC v3.2.x milestone Apr 10, 2024
@lahabana lahabana modified the milestones: KIC v3.2.x, KIC 3.3.x Jun 3, 2024
@lahabana lahabana modified the milestones: KIC v3.3.x, KIC v3.4.x Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CRD Changes in existing CRDs or introduction of new ones area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API priority/low
Projects
None yet
Development

No branches or pull requests

3 participants