Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasicAuth #16

Closed
nijikokun opened this issue Nov 14, 2013 · 3 comments
Closed

BasicAuth #16

nijikokun opened this issue Nov 14, 2013 · 3 comments

Comments

@nijikokun
Copy link
Contributor

To be consistent with the other libraries should be auth

@varra4u
Copy link
Contributor

varra4u commented May 26, 2015

I think basicAuth() holds good, since we are talking about specific authentication mechanism (i.e Basic Authentication) here in Unirest with basicAuth().

We know that JEE and some other third party libraries do use auth() as the method name since they do accept any kind of authentication mechanism like given below:

  1. BASIC
  2. DIGEST
  3. FORM
  4. CLIENT-CERT, or
  5. Any vendor-specific authentication scheme.

I think this is the secret behind the naming convention for basicAuth() .. ;-)

@RJPalombo
Copy link

I see the PHP lib supports other auth types. Will this lib only support basic? The PHP also shows the more generic "auth" method, then as a parameter you can specify what type.

@ryber
Copy link
Collaborator

ryber commented Mar 6, 2019

We should look in the future to support specific headers for various token types (like Bearer tokens) but for how the header methods support this just file

@ryber ryber closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants