New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve about page layout #195
Comments
Thanks for the update! Now I know I've missed something.. I'll revise it! |
@shaunkawano Maybe you are almost correct, so feel free to sent PR :) |
👍 |
And I'm sorry, I updated photo and text in description because it was wrong. Could you check it again? |
Yes, I've checked the screenshot above and I hope that I got it right.. Thank you! |
Take it easy. I'm glad and welcome any PR anytime. Thanks 😃 |
(∩´∀`)∩ < Glad to hear that! |
I guess it's already fixed. |
@hotchemi sorry for confusion but the tap areas and the ripple effects of social icons can be better. If not reusing this issue, would it be ok to create separate issue for it? |
@shaunkawano Sure! You can do that! |
@hotchemi OK! I'll create a separate issue for it then! :) Thank you! |
👍 |
ref: SNS buttons in detail page layout.
https://github.com/konifar/droidkaigi2016/blob/master/app/src/main/res/layout/view_speaker_sns_icons.xml#L36-L55
The text was updated successfully, but these errors were encountered: