Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve about page layout #195

Closed
konifar opened this issue Feb 13, 2016 · 12 comments
Closed

Improve about page layout #195

konifar opened this issue Feb 13, 2016 · 12 comments

Comments

@konifar
Copy link
Owner

konifar commented Feb 13, 2016

2016-02-13_17_34_49_png

ref: SNS buttons in detail page layout.
https://github.com/konifar/droidkaigi2016/blob/master/app/src/main/res/layout/view_speaker_sns_icons.xml#L36-L55

@shoheikawano
Copy link
Contributor

Hi! This issue seems reasonable amount of work for me so I've tried to resolve it; all I did was adding android:layout_marginBottom="@dimen/spacing_small" to the border view above the text 'ソーシャル'; I was going to modify the margin of @style/AboutTitle from 8dp to 16dp, but it was applied to the word 'DroidKaigiについて' as well so I decided not to do so. Now the screen looks like below. Before me making a pull request, could you check it and let me know if I've missed something when you have time?

Thanks for the update! Now I know I've missed something.. I'll revise it!

@konifar
Copy link
Owner Author

konifar commented Feb 13, 2016

@shaunkawano Maybe you are almost correct, so feel free to sent PR :)

@shoheikawano
Copy link
Contributor

👍

@konifar
Copy link
Owner Author

konifar commented Feb 13, 2016

And I'm sorry, I updated photo and text in description because it was wrong. Could you check it again?

@shoheikawano
Copy link
Contributor

Yes, I've checked the screenshot above and I hope that I got it right.. Thank you!

@konifar
Copy link
Owner Author

konifar commented Feb 13, 2016

Take it easy. I'm glad and welcome any PR anytime. Thanks 😃

@shoheikawano
Copy link
Contributor

(∩´∀`)∩ < Glad to hear that!

@hotchemi
Copy link
Contributor

I guess it's already fixed.

@hotchemi hotchemi removed the ready label Feb 15, 2016
@shoheikawano
Copy link
Contributor

@hotchemi sorry for confusion but the tap areas and the ripple effects of social icons can be better. If not reusing this issue, would it be ok to create separate issue for it?

@hotchemi
Copy link
Contributor

@shaunkawano Sure! You can do that!

@shoheikawano
Copy link
Contributor

@hotchemi OK! I'll create a separate issue for it then! :) Thank you!

@hotchemi
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants