Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NucleusActionBarActivity with support library 26 #147

Closed
aralizer opened this issue Aug 26, 2017 · 13 comments
Closed

NucleusActionBarActivity with support library 26 #147

aralizer opened this issue Aug 26, 2017 · 13 comments

Comments

@aralizer
Copy link

Hi,

I've recently updated my support library to version 26.0.1 which does not include the deprecated ActionBarActivity class. This causes an error while creating a release APK file saying that the NucleusActionBarActivity can't be compiled since it has unknown method references:

Warning:nucleus.view.NucleusActionBarActivity: can't find referenced method 'boolean isChangingConfigurations()' in program class nucleus.view.NucleusActionBarActivity

I've tried removing only this class with gradle's 'exclude', but with no success. So currently I'm adding the sources without the problematic class directly into my app sources...

I think this class should be removed from nucleus since it extends a class that has been removed from the android support library.

@TWiStErRob
Copy link

Don't exclude in Gradle, add

-dontwarn nucleus.view.NucleusActionBarActivity

to your ProGuard config. -- https://stackoverflow.com/a/23944940/253468

And make sure you're not using this class in your app.

@aralizer
Copy link
Author

It worked, thanks.

@TWiStErRob
Copy link

@konmik I think it's still a valid request to remove that class from your lib.

@konmik konmik reopened this Aug 28, 2017
@konmik
Copy link
Owner

konmik commented Sep 18, 2017

Past weekend I tried to reproduce this issue and failed. It relies on usage of beta dependencies as I understand. I can't make library depending on them, when everything will become final I'll update both (rx1 and rx2) versions.

@TWiStErRob
Copy link

@konmik Oreo (8/26) was released in August. API 26 support had 4 stable releases already, what do you mean by "become final"?

@sreejithraman
Copy link

i used 26.0.1 and didn't run into this issue... should i be concerned and are there any updates on this?

@konmik
Copy link
Owner

konmik commented Oct 11, 2017

You're welcome to send a PR. :)

Or wait till I will make the second attempt. I have some time this weekend.

@konmik
Copy link
Owner

konmik commented Oct 23, 2017

image

@konmik
Copy link
Owner

konmik commented Oct 23, 2017

Oh, I see: ActionBarActivity !

@TWiStErRob
Copy link

:) Yes, they renamed it a while ago, by extends, and deprecated the old one.

@TWiStErRob
Copy link

Did you see the repro PR?

@konmik
Copy link
Owner

konmik commented Oct 23, 2017

Yeah, I saw it, thanks! :) Gradle and maven repo are trying to confuse me, but I'm not giving up! :D Hope to update it today finally.

@konmik
Copy link
Owner

konmik commented Oct 23, 2017

Done! NucleusActionBarActivity removed, library version bumped, it will be available on maven central in several hours.

@konmik konmik closed this as completed Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants