New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NucleusActionBarActivity with support library 26 #147
Comments
Don't exclude in Gradle, add
to your ProGuard config. -- https://stackoverflow.com/a/23944940/253468 And make sure you're not using this class in your app. |
It worked, thanks. |
@konmik I think it's still a valid request to remove that class from your lib. |
Past weekend I tried to reproduce this issue and failed. It relies on usage of beta dependencies as I understand. I can't make library depending on them, when everything will become final I'll update both (rx1 and rx2) versions. |
@konmik Oreo (8/26) was released in August. API 26 support had 4 stable releases already, what do you mean by "become final"? |
i used 26.0.1 and didn't run into this issue... should i be concerned and are there any updates on this? |
You're welcome to send a PR. :) Or wait till I will make the second attempt. I have some time this weekend. |
Oh, I see: ActionBarActivity ! |
:) Yes, they renamed it a while ago, by |
Did you see the repro PR? |
Yeah, I saw it, thanks! :) Gradle and maven repo are trying to confuse me, but I'm not giving up! :D Hope to update it today finally. |
Done! |
Hi,
I've recently updated my support library to version 26.0.1 which does not include the deprecated ActionBarActivity class. This causes an error while creating a release APK file saying that the NucleusActionBarActivity can't be compiled since it has unknown method references:
I've tried removing only this class with gradle's 'exclude', but with no success. So currently I'm adding the sources without the problematic class directly into my app sources...
I think this class should be removed from nucleus since it extends a class that has been removed from the android support library.
The text was updated successfully, but these errors were encountered: