Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modify deepQuerySelectorAll behavior, add getAllElementsAndShadowRoots. #36

Merged
merged 6 commits into from Nov 11, 2022
Merged

feat: modify deepQuerySelectorAll behavior, add getAllElementsAndShadowRoots. #36

merged 6 commits into from Nov 11, 2022

Conversation

KonnorRogers
Copy link
Owner

@KonnorRogers KonnorRogers commented Nov 8, 2022 •
edited

  • deepQuerySelectorAll will no longer return shadowRoots or the container element.
  • The original deepQuerySelectorAll behavior has been replaced with getAllElementsAndShadowRoots

I've walked this back as a breaking change only because deepQuerySelector actually never really worked as intended anyways.

Fixes #33

@CreativeTechGuy CreativeTechGuy mentioned this pull request Nov 10, 2022
Closed
@KonnorRogers KonnorRogers changed the title BREAKING CHANGE: modify deepQuerySelectorAll behavior fix: modify deepQuerySelectorAll behavior Nov 11, 2022
@KonnorRogers KonnorRogers changed the title fix: modify deepQuerySelectorAll behavior feat: modify deepQuerySelectorAll behavior, add getAllElementsAndShadowRoots. Nov 11, 2022
@KonnorRogers KonnorRogers merged commit 697a0dc into main Nov 11, 2022
@KonnorRogers KonnorRogers deleted the konnorrogers/fix-recurse-into-container-shadow-root branch November 11, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deepQuerySelectorAll doesn't recurse into root container's shadowRoot
1 participant
@KonnorRogers