/
limiter.go
600 lines (524 loc) · 18.3 KB
/
limiter.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
package limiter
import (
"context"
"errors"
"fmt"
"io"
"math"
"math/rand"
"strconv"
"strings"
"time"
"log/slog"
"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/aws/retry"
"github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue"
"github.com/aws/aws-sdk-go-v2/feature/dynamodb/expression"
"github.com/aws/aws-sdk-go-v2/service/dynamodb"
"github.com/aws/aws-sdk-go-v2/service/dynamodb/types"
"github.com/google/uuid"
lru "github.com/hashicorp/golang-lru/v2"
)
var (
// TimeNow is global variable for mock
timeNow = time.Now
uuidNewRandom = uuid.NewRandom
_ LimitPreparer = &RateLimit{}
attrBucketIDShardID = "bucket_id_shard_id"
attrTTL = "ttl"
)
const (
delimiter = "#"
)
//go:generate mockgen -source=$GOFILE -destination=mock_$GOPACKAGE/$GOFILE -package=mock_$GOPACKAGE
type LimitPreparer interface {
Limiter
Preparer
}
type Limiter interface {
ShouldThrottle(context.Context, string) (bool, error)
}
type Preparer interface {
PrepareTokens(context.Context, string) error
}
type RateLimit struct {
client *wrappedDDBClient
bucket *TokenBucket
tableName string
anonymous bool
ttl time.Duration
ncache *lru.Cache[string, interface{}]
maxLength int
baseLogger *slog.Logger
}
type ddbItem struct {
BucketIDShardID string `dynamodbav:"bucket_id_shard_id" json:"bucket_id_shard_id"`
TokenCount int64 `dynamodbav:"token_count" json:"token_count"`
// milliseconds unix timestamp
LastUpdated int64 `dynamodbav:"last_updated" json:"last_updated"`
TTL int64 `dynamodbav:"ttl" json:"ttl"`
shardID int64
bucketID string
}
type Opt func(rl *RateLimit)
func WithEMFMetrics(w io.Writer) Opt {
return func(rl *RateLimit) {
rl.client = newWrapDDBClient(rl.client.c, w)
}
}
func WithLogger(logger *slog.Logger) Opt {
return func(rl *RateLimit) {
rl.baseLogger = logger
}
}
func withAnonymous(ttl time.Duration) Opt {
return func(rl *RateLimit) {
rl.anonymous = true
rl.ttl = ttl
}
}
func withNegativeCache(size int) Opt {
return func(rl *RateLimit) {
rl.ncache.Resize(size)
}
}
func New(cfg *Config, client DDBClient, opts ...Opt) (*RateLimit, error) {
interval := DefaultInterval
if cfg.Interval != 0 {
interval = cfg.Interval
}
bucket, err := newTokenBucket(
cfg.TokenPerInterval,
cfg.BucketSize,
interval)
if err != nil {
return nil, err
}
if cfg.TableName == "" {
return nil, errors.New("table_name in config is empty")
}
addOpts, err := cfgToOpts(cfg.AdditionalConfig)
if err != nil {
return nil, err
}
addOpts = append(addOpts, opts...)
l := newLimiter(cfg.TableName, bucket, client, addOpts...)
return l, nil
}
func newLimiter(table string, bucket *TokenBucket, client DDBClient, opts ...Opt) *RateLimit {
l := &RateLimit{
bucket: bucket,
tableName: table,
client: newWrapDDBClient(client, io.Discard),
ncache: defaultCache,
maxLength: 512, // a WCU is 1kib basis
// disabled by default
baseLogger: slog.New(slog.NewJSONHandler(io.Discard, &slog.HandlerOptions{Level: slog.Level(-1)})),
}
for _, opt := range opts {
if opt != nil {
opt(l)
}
}
return l
}
func pickIndex(min int) int {
i := rand.Intn(min) //nolint:gosec,gocritic
return i
}
// ShouldThrottle return throttled and an error. If throttle is true, it means tokens run out.
// If an error is ErrRateLimitExceeded, DynamoDB API rate limit exceeded.
func (l *RateLimit) ShouldThrottle(ctx context.Context, bucketID string) (bool, error) {
if bucketID == "" {
return true, fmt.Errorf("empty bucket id: %w", ErrInvalidBucketID)
}
// bucket size is zero
shardIDs := l.bucket.makeShards()
if len(shardIDs) == 0 || l.bucket.numOfShards == 0 {
return true, nil
}
i := pickIndex(len(shardIDs))
shardID := shardIDs[i]
return l.shouldThrottle(ctx, bucketID, shardID)
}
func (l *RateLimit) shouldThrottle(ctx context.Context, bucketID string, shardID int64) (throttled bool, err error) {
logger := l.baseLogger.With(
slog.String("table_name", l.tableName),
slog.String("bucket_id", bucketID),
slog.Int64("shard_id", shardID),
slog.Int("negative_cache_entries", l.ncache.Len()),
)
defer func() { logger.DebugContext(ctx, fmt.Sprintf("result throttled: %v", throttled)) }()
if l.maxLength < len(bucketID) {
return true, fmt.Errorf("exceeded maximum bucket id length %d: %w", l.maxLength, ErrInvalidBucketID)
}
if bucketID != "" && l.ncache.Contains(bucketID) {
return true, fmt.Errorf("found in negative cache: %w", ErrInvalidBucketID)
}
token, err := l.getToken(ctx, logger, bucketID, shardID)
throttle := token <= 0
defer func() {
if err != nil {
// add context to an error
err = fmt.Errorf("bucketID %s, shardID %d: %w", bucketID, shardID, err)
}
}()
// add negative cache and early return
if errors.Is(err, ErrInvalidBucketID) {
logger.DebugContext(ctx, "adding into the negative cache")
l.ncache.Add(bucketID, nil)
return true, err
}
// other throttle will be caught here to record metrics
if throttle {
outputLog(l.client.metricOut, buildThrottleMetric(l.tableName, bucketID, int64String(shardID)))
}
// ignore ConditionalCheckFailed
if isErrConditionalCheckFailed(err) {
return throttle, nil
}
return throttle, err
}
// getToken consumes a token and returns available tokens. it will tell dynamodb errors to the caller.
func (l *RateLimit) getToken(ctx context.Context, logger *slog.Logger, bucketID string, shardID int64) (count int64, err error) {
item, err := l.getTokenItem(ctx, logger, bucketID, shardID)
if err != nil {
return 0, err
}
defer func() {
if isErrLimitExceeded(err) || errors.Is(err, ErrRateLimitExceeded) {
logger.WarnContext(ctx, fmt.Sprintf("encountered DynamoDB API limits: %v", err))
count = 0
}
}()
now := timeNow().UnixMilli()
token := item.TokenCount
refillTokenCount := l.calculateRefillToken(item, now)
logger.DebugContext(ctx, fmt.Sprintf("current tokens: %d, refilled token: %d", token, refillTokenCount))
switch {
case refillTokenCount > 0:
// store subtracted token as a token will be used for get-token
err := l.refillToken(ctx, logger, bucketID, shardID, refillTokenCount-1, item.LastUpdated, now)
if err != nil {
if isErrConditionalCheckFailed(err) {
// fallback to subtract, when succeeded, available one token at least.
logger.DebugContext(ctx, "refill-token failed due to conditional check failed, fallbacking to subtract-token")
if err := l.subtractToken(ctx, logger, bucketID, shardID, now); err != nil {
if isErrConditionalCheckFailed(err) {
// if ConditionalCheckFailedException, it means tokens run out by other request.
logger.DebugContext(ctx, "tokens run out: subtract-token for the fallback failed due to conditional check failed")
return 0, err
}
// an internal error at subtractToken
logger.ErrorContext(ctx, fmt.Sprintf("subtract-token encountered an unexpected error: %v", err))
return 0, errors.Join(err, ErrInternal)
}
// subtractToken successfully
return 1, err
}
// an internal error at refillToken
logger.ErrorContext(ctx, fmt.Sprintf("refill-token encountered an unexpected error: %v", err))
return 0, errors.Join(err, ErrInternal)
}
// available token are current token count + refill token count
return token + refillTokenCount, nil
case token > 0:
err := l.subtractToken(ctx, logger, bucketID, shardID, now)
if err != nil {
if isErrConditionalCheckFailed(err) {
logger.DebugContext(ctx, "tokens run out. subtract-token failed due to conditional check failed.")
// if ConditionalCheckFailedException, it means tokens run out by other request.
return 0, err
}
// an internal error at subtractToken
logger.ErrorContext(ctx, fmt.Sprintf("subtract-token encountered an unexpected error: %v", err))
return 0, errors.Join(err, ErrInternal)
}
logger.DebugContext(ctx, "subtract-token succeeded")
return 1, nil
default:
logger.DebugContext(ctx, "tokens run out")
return 0, nil
}
}
func (l *RateLimit) getTokenItem(ctx context.Context, logger *slog.Logger, bucketID string, shardID int64) (_ *ddbItem, retErr error) {
logger = logger.WithGroup("get_token_item")
input := &dynamodb.GetItemInput{
Key: buildPartitionKey(bucketID, shardID),
TableName: &l.tableName,
}
resp, err := l.client.GetItem(ctx, logger, input)
if err != nil {
logger.ErrorContext(ctx, fmt.Sprintf("get-token-item failed: %v", err))
return nil, fmt.Errorf("get-token-item: %w", err)
}
// check registered token or not
if len(resp.Item) == 0 {
if l.anonymous && l.ttl > 0 {
// return temporary token as create operation is executed by refillToken().
// avoid to call prepareTokens() API.
i := &ddbItem{
BucketIDShardID: makePartitionKey(bucketID, shardID),
TokenCount: 0,
LastUpdated: timeNow().
Add(-l.bucket.interval * time.Duration(l.bucket.bucketSizePerShard[shardID])).
UnixMilli(),
bucketID: bucketID,
shardID: shardID,
}
logger.DebugContext(ctx, "created ddb item for anonymous mode", slog.Any("ddb_item", i))
return i, nil
}
logger.DebugContext(ctx, "unregistered bucket id")
return nil, fmt.Errorf("unregistered bucket id: %w", ErrInvalidBucketID)
}
item := new(ddbItem)
if err := attributevalue.UnmarshalMap(resp.Item, item); err != nil {
logger.ErrorContext(ctx, fmt.Sprintf("get-token-item unmarshal failed: %v", err))
return nil, err
}
// add internal value
item.bucketID, item.shardID = bucketID, shardID
logger.DebugContext(ctx, "got token item", slog.Any("ddb_item", item))
return item, nil
}
func (l *RateLimit) calculateRefillToken(item *ddbItem, now int64) int64 {
num := math.Floor(float64((now - item.LastUpdated)) / float64(l.bucket.interval.Milliseconds()))
if num < 0 {
return 0
}
refill := l.bucket.tokensPerShardPerInterval[item.shardID] * int64(num)
burstable := l.bucket.bucketSizePerShard[item.shardID] - item.TokenCount
if refill > burstable {
return burstable
}
return refill
}
// refillToken if return an error of ConditionalCheckFailedException, this means other request has been accepted before this request
func (l *RateLimit) refillToken(ctx context.Context, logger *slog.Logger,
bucketID string, shardID, refillTokenCount, lastUpdated, now int64) error {
logger = logger.WithGroup("refill_token")
shardBurstSize := l.bucket.bucketSizePerShard[shardID]
condNotExist := expression.Name("bucket_id").AttributeNotExists()
// Check last_updated is equal to last_updated of got item to achieve strong write consistency.
// Other refillToken request is accepted before this, it will cause ConditionalCheckFailedException.
// It avoid to refill tokens unexpectedly.
// last_update == lastUpdated of got item
condUpdated := expression.Name("last_updated").
Equal(expression.Value(lastUpdated)).
And(
// token_count < burstable size
expression.ConditionBuilder(expression.Name("token_count").
LessThan(expression.Value(shardBurstSize))),
)
condExpr := condNotExist.Or(expression.ConditionBuilder(condUpdated))
updateExpr := expression.
Set(
expression.Name("last_updated"), expression.Value(now)).
Add(
expression.Name("token_count"), expression.Value(refillTokenCount),
)
updateExpr = l.updateTTLExpr(updateExpr, now)
expr, err := expression.NewBuilder().WithCondition(condExpr).WithUpdate(updateExpr).Build()
if err != nil {
logger.ErrorContext(ctx, fmt.Sprintf("refill build failed: %v", err))
return fmt.Errorf("refill build: %w", err)
}
input := &dynamodb.UpdateItemInput{
TableName: &l.tableName,
Key: buildPartitionKey(bucketID, shardID),
ExpressionAttributeNames: expr.Names(),
ExpressionAttributeValues: expr.Values(),
UpdateExpression: expr.Update(),
ConditionExpression: expr.Condition(),
ReturnValues: types.ReturnValueNone,
}
if _, err := l.client.UpdateItem(ctx, logger, input); err != nil {
// TODO return custom error if CCF
logger.DebugContext(ctx, "refill-token failed: %w")
return fmt.Errorf("refill-token: %w", err)
}
logger.DebugContext(ctx, "refill-token succeeded")
return nil
}
// subtractToken if return an error of ConditionalCheckFailedException, this means token has been zero by other request.
func (l *RateLimit) subtractToken(ctx context.Context, logger *slog.Logger, bucketID string, shardID, now int64) error {
logger = logger.WithGroup("subtract_token")
// if other request subtract token before this and token run out, ConditionalCheckFailedException will occur.
// No handling the error here
// "token_count > :min_val"
condExpr := expression.Name("token_count").GreaterThan(expression.Value(0))
// "SET last_updated = :now ADD token_count :mod"
updateExpr := expression.Set(
expression.Name("last_updated"),
expression.Value(now)).
Add(
expression.Name("token_count"),
expression.Value(-1),
)
updateExpr = l.updateTTLExpr(updateExpr, now)
expr, err := expression.NewBuilder().WithCondition(condExpr).WithUpdate(updateExpr).Build()
if err != nil {
return fmt.Errorf("subtract build: %w", err)
}
input := &dynamodb.UpdateItemInput{
Key: buildPartitionKey(bucketID, shardID),
TableName: &l.tableName,
ExpressionAttributeNames: expr.Names(),
ExpressionAttributeValues: expr.Values(),
UpdateExpression: expr.Update(),
ConditionExpression: expr.Condition(),
ReturnValues: types.ReturnValueNone,
}
if _, err := l.client.UpdateItem(ctx, logger, input); err != nil {
// TODO return custom error if CCF
logger.DebugContext(ctx, "subtract-token failed: %w")
return fmt.Errorf("subtract-item: %w", err)
}
logger.DebugContext(ctx, "subtract-token succeeded")
return nil
}
func (l *RateLimit) updateTTLExpr(expr expression.UpdateBuilder, now int64) expression.UpdateBuilder {
if l.anonymous && l.ttl > 0 {
expr = expr.Set(
expression.Name(attrTTL),
// second unix timestamp
expression.Value(time.UnixMilli(now).Unix()+int64(l.ttl.Seconds())),
)
}
return expr
}
func (l *RateLimit) PrepareTokens(ctx context.Context, bucketID string) (err error) {
shards := l.bucket.makeShards()
now := timeNow().UnixMilli()
batchSize := 25
logger := l.baseLogger.With(slog.String("bucket_id", bucketID))
logger.DebugContext(ctx, fmt.Sprintf("distribute %d shards", len(shards)))
for i := 0; i < len(shards); i += batchSize {
if len(shards) < batchSize+i {
logger.DebugContext(ctx, fmt.Sprintf("processing %d - %d partial shards", i, len(shards)-1))
return l.prepareTokens(ctx, logger, bucketID, now, shards[i:])
}
logger.DebugContext(ctx, fmt.Sprintf("processing %d - %d shards", i, i+batchSize-1))
if err := l.prepareTokens(ctx, logger, bucketID, now, shards[i:i+batchSize]); err != nil {
return err
}
}
return nil
}
func (l *RateLimit) prepareTokens(ctx context.Context, logger *slog.Logger, bucketID string, now int64, shards []int64) error {
requests := make([]types.WriteRequest, len(shards))
for i, shardID := range shards {
item := &ddbItem{
BucketIDShardID: makePartitionKey(bucketID, shardID),
LastUpdated: now,
TokenCount: l.bucket.bucketSizePerShard[shardID],
}
attrs, err := attributevalue.MarshalMap(item)
if err != nil {
return fmt.Errorf("prepare build: %w", err)
}
requests[i] = types.WriteRequest{
PutRequest: &types.PutRequest{Item: attrs},
}
}
input := &dynamodb.BatchWriteItemInput{
RequestItems: map[string][]types.WriteRequest{
l.tableName: requests,
},
}
err := l.retryBatchWriteItem(ctx, logger, input)
if err != nil {
logger.DebugContext(ctx, "prepare tokens failed")
return fmt.Errorf("prepare-tokens: %w", err)
}
logger.DebugContext(ctx, "prepare tokens succeeded")
return nil
}
func (l *RateLimit) retryBatchWriteItem(ctx context.Context, logger *slog.Logger, input *dynamodb.BatchWriteItemInput) error {
b := retry.NewExponentialJitterBackoff(retry.DefaultMaxBackoff)
items := input.RequestItems
for i := 0; i < retry.DefaultMaxAttempts; i++ {
input.RequestItems = items
resp, err := l.client.BatchWriteItem(ctx, logger, input)
if err != nil {
return err
}
// update items
items = resp.UnprocessedItems
if len(items) == 0 {
return nil
}
delay, err := b.BackoffDelay(i, nil)
if err != nil {
return fmt.Errorf("backoff delay: %w", err)
}
time.Sleep(delay)
}
return fmt.Errorf("exceeded maximum retry count")
}
func int64String(v int64) string {
return strconv.FormatInt(v, 10)
}
func buildPartitionKey(bucketID string, shardID int64) map[string]types.AttributeValue {
bucketIDShardID := makePartitionKey(bucketID, shardID)
return map[string]types.AttributeValue{
attrBucketIDShardID: &types.AttributeValueMemberS{
Value: bucketIDShardID,
},
}
}
func makePartitionKey(bucketID string, shardID int64) string {
return fmt.Sprintf("%s%s%d", bucketID, delimiter, shardID)
}
func splitPartitionKey(bucketIDShardID string) (bucketID, shardID string, _ error) {
idx := strings.LastIndex(bucketIDShardID, delimiter)
invalidErr := fmt.Errorf("unexpected partition key: %s", bucketIDShardID)
if idx <= 0 {
return "", "", invalidErr
}
bucketID = bucketIDShardID[:idx]
shardID = bucketIDShardID[idx+1:]
if bucketID == "" || shardID == "" {
return "", "", invalidErr
}
return bucketIDShardID[:idx], bucketIDShardID[idx+1:], nil
}
func CreateTable(ctx context.Context, tableName string, client *dynamodb.Client) error {
input := &dynamodb.CreateTableInput{
TableName: &tableName,
BillingMode: types.BillingModePayPerRequest,
KeySchema: []types.KeySchemaElement{
{
AttributeName: &attrBucketIDShardID,
KeyType: types.KeyTypeHash,
},
},
AttributeDefinitions: []types.AttributeDefinition{
{
AttributeName: &attrBucketIDShardID,
AttributeType: types.ScalarAttributeTypeS,
},
},
}
_, err := client.CreateTable(ctx, input)
var ae *types.TableAlreadyExistsException
var ie *types.ResourceInUseException
if errors.As(err, &ae) || errors.As(err, &ie) {
return nil
}
waiter := dynamodb.NewTableExistsWaiter(client)
err = waiter.Wait(ctx, &dynamodb.DescribeTableInput{TableName: aws.String(tableName)}, 1*time.Minute)
if err != nil {
return err
}
ttlInput := &dynamodb.UpdateTimeToLiveInput{
TableName: &tableName,
TimeToLiveSpecification: &types.TimeToLiveSpecification{
Enabled: aws.Bool(true),
AttributeName: &attrTTL,
},
}
_, err = client.UpdateTimeToLive(ctx, ttlInput)
return err
}