Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open PRs transferred from Orange repo with history rewritten to remove original author #25

Closed
cannonpalms opened this issue Mar 22, 2022 · 3 comments

Comments

@cannonpalms
Copy link
Contributor

cannonpalms commented Mar 22, 2022

Hi,

Can I ask what happened to PRs such as (#18, #24) when they were moved over to this repo? The original author no longer appears anywhere, not even their sign-off trailers. @erdrix / @juldrixx now appear as the author of these commits.

Thanks,
Cannon

@erdrix
Copy link
Contributor

erdrix commented Mar 23, 2022

Hi,
Yes, I'm sorry about that ...

We wanted to go as fast as possible on the new repo and integrate all remaining open PRs because they were open for so long, that the easiest approach was to : copy/paste the PRs changes > review / fix > publish

And we can't do that on the Orange repo due to lack of rights on the repo.

In the last PR (#4), I tried to fix this by cherry-pick @genehynson's changes, it is not elegant but at least he appears in the contributors !

Again really sorry for this, we wanted to go fast to boost operator activity, maybe we were wrong :/

@genehynson
Copy link
Contributor

Thanks for the explanation - no worries. I appreciate the effort both of you are making to get these PRs merged! It's really exciting to see the project moving forward. We're looking forward to making more contributions in the near future 😃

@cannonpalms
Copy link
Contributor Author

Thanks for the response. How you went about this is understandable. Forks on GH are a bit of a mess.

cannonpalms referenced this issue in influxdata/nifikop Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants