Support for Kotlin 1.3.0 #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi! Is there any plans to merge it anytime soon? |
meshpaul
reviewed
Jan 3, 2019
| @@ -16,7 +16,7 @@ | |||
|
|
|||
| package org.springframework.kotlin.experimental.coroutine.util; | |||
There was a problem hiding this comment.
I think experimental can be dropped from package itself
meshpaul
reviewed
Jan 3, 2019
| @@ -1,6 +1,6 @@ | |||
| buildscript { | |||
| ext.kotlin_version = "1.2.70" | |||
| ext.kotlin_coroutines_version = "0.26.0" | |||
| ext.kotlin_version = "1.3.0" | |||
meshpaul
reviewed
Jan 3, 2019
| ext.kotlin_version = "1.2.70" | ||
| ext.kotlin_coroutines_version = "0.26.0" | ||
| ext.kotlin_version = "1.3.0" | ||
| ext.kotlin_coroutines_version = "1.0.1" |
meshpaul
reviewed
Jan 3, 2019
| @@ -16,8 +16,8 @@ | |||
|
|
|||
| package org.springframework.kotlin.experimental.coroutine.util | |||
|
Any movement on this? Sitting for 2 months now... |
domgom
added a commit
to domgom/spring-kotlin-coroutine
that referenced
this pull request
Feb 12, 2019
…nd kotlin_coroutines_version 1.1.1
|
See #44 (comment). |
SergeyFirst
approved these changes
Feb 25, 2019
|
Closing due to #44 being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes:
kotlin.coroutines,kotlinx.coroutinesrelated package nameskotlinx.coroutines, therefore I've removed RxJava 1.x supports.Continuation<T>'s method changes (resume,resumeWithException->resumeWith)