Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of other social profiles #6

Closed
alopezari opened this issue Oct 28, 2021 · 4 comments
Closed

Addition of other social profiles #6

alopezari opened this issue Oct 28, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@alopezari
Copy link

alopezari commented Oct 28, 2021

Hi!

First of all thank for sharing this awesome portfolio starter with us, it looks amazing :)

I started playing with it and wanted to add other social profiles, like Twitter, for instance. I added it to the configuration file inside the content path (just where the other social profiles are) but Gatsby raised an error when loading the page, saying something like "unknown social profile".

Probably I'm missing something. Is there an easy way to change/add other social profiles?

Thanks!

@konstantinmuenster
Copy link
Owner

Hi @alopezari! Glad to hear that, thanks a lot 👋

Regarding your issue: No, actually you don't miss anything. I just didn't come to add more social profiles yet 😄 So, only a few are available and can be added. Which platforms do you need in specific? I will add them to the theme, then you just need to update your gatsby-theme-portfolio-minimal package and you can use them.

If you want to add your own custom profiles instead, you would have to do the following:

  1. Extend the SocialProfiles component and its configuration with your custom platforms. You can do this by theme shadowing.
  2. Add the platform's icon in the icons directory and extend the Icon component accordingly. This can be done via shadowing as well.

Whatsoever, you can also just give me the missing social profile platforms and I will add them. Then, they will be available to everyone ☺️

@konstantinmuenster konstantinmuenster self-assigned this Oct 30, 2021
@konstantinmuenster konstantinmuenster added the enhancement New feature or request label Oct 30, 2021
@alopezari
Copy link
Author

Hi @konstantinmuenster , thanks for your response!

The only social profile I miss there is Twitter, I think it will be useful for other people as well since it's one of the most used social networks for developers. It would be great if you could add it to the theme.

However, we're here to learn, so I will try to add it on my own too. Thanks for the explanation!

@konstantinmuenster
Copy link
Owner

konstantinmuenster commented Oct 30, 2021

@alopezari Alright, it has been more to it than what I mentioned. You can check here what I changed. I also just released an updated version of the theme. So you can update to v2.6.4 and should be able to add a Twitter profile.

Hopefully, this works for you ☺️

@alopezari
Copy link
Author

Wow, thank you very much for the super fast update! Looking forward to updating the version and checking your changes.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants