Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason sysctl values are cast to integer? #149

Closed
KoenDG opened this issue Aug 28, 2022 · 2 comments
Closed

Is there a reason sysctl values are cast to integer? #149

KoenDG opened this issue Aug 28, 2022 · 2 comments
Assignees

Comments

@KoenDG
Copy link
Contributor

KoenDG commented Aug 28, 2022

See here:

value: "{{ item.value | int }}"

Certain values can have more than 1 setting. Example:

net.ipv4.tcp_wmem: 4096 87380 8388608

Granted, that isn't a security/hardening related setting. So I'm just wondering if it would be ok to remove the cast, or leave it in as long as it doesn't come up for a hardening-related idea.

@konstruktoid
Copy link
Owner

No particular reason except that all defaults (https://github.com/konstruktoid/ansible-role-hardening/blob/master/defaults/main/sysctl.yml) are basic integers.

If other values are added that isn't integers, the cast should be removed.

@KoenDG
Copy link
Contributor Author

KoenDG commented Aug 29, 2022

Alright, since there appears to be no need for that right now, I'll close this.

@KoenDG KoenDG closed this as completed Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants