Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null safety support #22

Closed
andzejsw opened this issue Mar 12, 2021 · 11 comments
Closed

Null safety support #22

andzejsw opened this issue Mar 12, 2021 · 11 comments
Labels
enhancement New feature or request

Comments

@andzejsw
Copy link

Package currently isn't supporting flutter 2.0 null safety logic.

@konsultaner
Copy link
Owner

I thought about it and found out that at the moment not all deps have nullsafty yet. I will start working at this as soon as all deps are nullsafe.

@konsultaner konsultaner added the enhancement New feature or request label Mar 12, 2021
@andzejsw
Copy link
Author

Dependencies:
pointycastle: Prerelease: 3.0.0-nullsafety.2
logging: 1.0.0 null safe
pedantic: 1.11.0 null safe
meta: 1.3.0 null safe
msgpack_dart: 1.0.0 null safe
saslprep is your package @konsultaner as far as i understand. So looks like that all main dependencies are nulls safe.

Also both dev dependencies are null safe.

@konsultaner
Copy link
Owner

Seems like I have to start earlier then I thought. The problem I saw was bouncy castle. It kind of stopped development. Seems like they have continued there work. Thanks for checking my deps ✌️

@andzejsw
Copy link
Author

@konsultaner I have created new PR (#31) regarding this issue. Hope it will help to speed up development. :)

@konsultaner
Copy link
Owner

Oh cool Thanks! What happened to the code coverage? Did you remove Tests?

@andzejsw
Copy link
Author

andzejsw commented Mar 31, 2021

Oh cool Thanks! What happened to the code coverage? Did you remove Tests?

To be honest i don't know what is reason. I rewrited code, to use null safety logic. That involved a lot of null checks. Possibly some of that was reason, why coverage rating decreased.

@andzejsw
Copy link
Author

Oh cool Thanks! What happened to the code coverage? Did you remove Tests?

Maybe you can try to take a look. when you have time. But no rush.

@konsultaner
Copy link
Owner

@andzejsw @oberstet Could someone confirm https://github.com/konsultaner/connectanum-dart/tree/sound-null-safety does work in production? I would like to finally support sound null safety.

@oberstet
Copy link
Contributor

oberstet commented Nov 2, 2021

@konsultaner I'm not currently doing Dart stuff .. test quickly. OP might .. actually I don't know

@konsultaner
Copy link
Owner

@oberstet ok, thank you! I'll merge it. Upcoming issues will be posted anyways. . So What 🤔

@oberstet
Copy link
Contributor

oberstet commented Nov 4, 2021

@konsultaner cool, thanks for moving things forward!

btw, as we are talking here, and rgd the way forward with WAMP/Crossbar.io etc, you might be interested in wamp-proto/wamp-proto#387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants