Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output is scrambled after command throws error #31

Closed
jakolehm opened this issue Oct 3, 2017 · 1 comment
Closed

Output is scrambled after command throws error #31

jakolehm opened this issue Oct 3, 2017 · 1 comment
Assignees
Labels

Comments

@jakolehm
Copy link
Contributor

jakolehm commented Oct 3, 2017

No description provided.

@kke
Copy link
Contributor

kke commented Oct 4, 2017

How to reproduce? Making a command simply raise does not garble output for me.

Raising during a spinner does seem to silence output completely:

class Nodes::ListCommand
  def execute
    spinner 'foo' do
      raise "foofoo"
    end
end
compose-e2e/e2e  > node ls
 [fail] foo
 [error] RuntimeError : foofoo
compose-e2e/e2e  > stack reg search
compose-e2e/e2e  > stack --help
compose-e2e/e2e  >

This is probably because spinner hijacks puts.

This may be an issue that has to be fixed in cli, any threads left behind by Kontena.run need to be killed after the command is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants