Script executions do not fail the entire process

[jnummelin]

Cri-o setup is really flaky since the repos are failing. Fixing those is a separate issue, but reveals another bug we have. Now when the crio setup script fails, we still continue the setup process as-if the setup did go through:

 Configuring container runtime (cri-o) packages ...
    +     mkdir     -p     /etc/systemd/system/crio.service.d    
    + cat
    + apt-get install -y cri-o-1.9
    Reading package lists...    
    Building dependency tree...    
    Reading state information...    
    The following additional packages will be installed:
      cri-o-runc dirmngr gnupg-agent gnupg2 libassuan0 libgpgme11 libksba8
      libnpth0 pinentry-curses skopeo-containers
    Suggested packages:
      containernetworking-plugins gnupg-doc parcimonie xloadimage gpgsm
      pinentry-doc
    The following NEW packages will be installed:
      cri-o-1.9 cri-o-runc dirmngr gnupg-agent gnupg2 libassuan0 libgpgme11
      libksba8 libnpth0 pinentry-curses skopeo-containers
    0 upgraded, 11 newly installed, 0 to remove and 12 not upgraded.
    Need to get 9,903 kB of archives.
    After this operation, 43.4 MB of additional disk space will be used.
    Get:1 http://ppa.launchpad.net/projectatomic/ppa/ubuntu xenial/main amd64 cri-o-runc amd64 1.0.0-rc4.5-2~ubuntu16.04.2~ppa1 [1,524 kB]
    Get:2 http://archive.ubuntu.com/ubuntu xenial/main amd64 libassuan0 amd64 2.4.2-2 [34.6 kB]
    Get:3 http://archive.ubuntu.com/ubuntu xenial/main amd64 pinentry-curses amd64 0.9.7-3 [31.2 kB]
    Get:4 http://archive.ubuntu.com/ubuntu xenial/main amd64 libnpth0 amd64 1.2-3 [7,998 B]
    Get:5 http://ppa.launchpad.net/projectatomic/ppa/ubuntu xenial/main amd64 skopeo-containers amd64 0.1.28-2~ubuntu16.04.2~ppa5 [3,788 B]
    Err:5 http://ppa.launchpad.net/projectatomic/ppa/ubuntu xenial/main amd64 skopeo-containers amd64 0.1.28-2~ubuntu16.04.2~ppa5
      Hash Sum mismatch
    Get:6 http://ppa.launchpad.net/projectatomic/ppa/ubuntu xenial/main amd64 cri-o-1.9 amd64 1.9.10-1~ubuntu16.04.2~ppa1 [6,874 kB]
    Get:7 http://archive.ubuntu.com/ubuntu xenial/main amd64 gnupg-agent amd64 2.1.11-6ubuntu2 [239 kB]
    Get:8 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 libksba8 amd64 1.3.3-1ubuntu0.16.04.1 [90.2 kB]
    Get:9 http://archive.ubuntu.com/ubuntu xenial/main amd64 gnupg2 amd64 2.1.11-6ubuntu2 [756 kB]
    Get:10 http://archive.ubuntu.com/ubuntu xenial/main amd64 libgpgme11 amd64 1.6.0-1 [108 kB]
    Get:11 http://archive.ubuntu.com/ubuntu xenial/main amd64 dirmngr amd64 2.1.11-6ubuntu2 [235 kB]
    Fetched 9,902 kB in 2s (3,470 kB/s)
    E    :     Failed to fetch http://ppa.launchpad.net/projectatomic/ppa/ubuntu/pool/main/s/skopeo/skopeo-containers_0.1.28-2~ubuntu16.04.2~ppa5_amd64.deb  Hash Sum mismatch
    
    E    :     Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?    
    Failed to execute configure-cri-o.sh
    Configuring kubelet ...
...

IMO these setup scripts failing should terminate the whole process immediately.

[jakolehm]

Does this happen also with master branch?

[jnummelin]

Does this happen also with master branch?

Yes.

The issue is that the ConfigureHost phase has

    rescue Kupo::Error => exc
      logger.error { exc.message }
    end

in its call method. This makes the phase executor to think everything went ok... I'll open a PR soon to fix.