Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Zipfile service has no axios retry logic #18

Closed
owain68 opened this issue Jun 15, 2021 · 1 comment
Closed

Zipfile service has no axios retry logic #18

owain68 opened this issue Jun 15, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@owain68
Copy link

owain68 commented Jun 15, 2021

Motivation

On exporting large number of assets to binary files I have had to perform a number of re-runs due to node throwing the axios exception ECONNRESET when retrieving from the CDN(!!)

Proposed solution

It would be pertinent to have axios perform some sort of retry logic in the code before throwing an exception. Perhaps this could be made configurable.

Additional context

https://github.com/Kentico/kontent-backup-manager-js/blob/eb532298c10991276ab0464842b32315803eb4eb/lib/zip/zip.service.ts#L196

@Enngage Enngage self-assigned this Jun 15, 2021
@Enngage Enngage added the enhancement New feature or request label Jun 15, 2021
@Enngage
Copy link
Contributor

Enngage commented Jun 15, 2021

Implemented in 2.0.0-next.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants