fix: Removes unnecessary usage of project validation endpoint

kontent-ai-bot · May 4, 2022 · 973c35b · 973c35b
1 parent b7e7fc6
commit 973c35b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 12 deletions.
diff --git a/lib/export/export.models.ts b/lib/export/export.models.ts
@@ -37,5 +37,5 @@ export interface IExportData {
 export interface IExportAllResult {
     metadata: IPackageMetadata;
     data: IExportData;
-    validation: ProjectContracts.IProjectReportResponseContract | {};
+    validation: ProjectContracts.IProjectReportResponseContract | undefined;
 }
diff --git a/lib/export/export.service.ts b/lib/export/export.service.ts
@@ -89,7 +89,7 @@ export class ExportService {
                     workflowStepsCount: data.workflowSteps.length
                 }
             },
-            validation: projectValidation ?? {},
+            validation: projectValidation,
             data
         };
     }

diff --git a/lib/node/cli/app.ts b/lib/node/cli/app.ts
@@ -76,21 +76,24 @@ const backupAsync = async (config: ICliFileConfig) => {
         context: 'node.js'
     });
 
-    const report = await exportService.exportProjectValidationAsync();
-
     const response = await exportService.exportAllAsync();
-    const zipFileData = await zipService.createZipAsync(response);
 
-    await fileService.writeFileAsync(config.zipFilename, zipFileData);
+    const validation = response.validation;
 
-    if (exportContainsInconsistencies(report)) {
-        const logFilename: string = getLogFilename(config.zipFilename);
+    if (validation) {
+        if (exportContainsInconsistencies(validation)) {
+            const logFilename: string = getLogFilename(config.zipFilename);
+
+            console.log(`Project contains inconsistencies which may cause errors during project import.`);
+            console.log(`See '${logFilename}' for more details.`);
+        } else {
+            console.log(`Project does not contain any inconsistencies`)
+        }
+    }
 
-        await fileHelper.createFileInCurrentFolderAsync(logFilename, JSON.stringify(report));
+    const zipFileData = await zipService.createZipAsync(response);
 
-        console.log(`Project contains inconsistencies which may cause future import to not work.`);
-        console.log(`See '${logFilename}' for more details.`);
-    }
+    await fileService.writeFileAsync(config.zipFilename, zipFileData);
 
     console.log('Completed');
 };