Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle long urls and notify users appropriately #28

Closed
Enngage opened this issue Oct 25, 2017 · 4 comments
Closed

Handle long urls and notify users appropriately #28

Enngage opened this issue Oct 25, 2017 · 4 comments

Comments

@Enngage
Copy link
Contributor

Enngage commented Oct 25, 2017

No description provided.

@Enngage
Copy link
Contributor Author

Enngage commented Sep 4, 2018

There is no universal value for maximum number of characters in URL and SDK should not dictate this either. Developers using SDK will have to make sure their URLs are valid for their own purposes.

@Enngage Enngage closed this as completed Sep 4, 2018
@Enngage
Copy link
Contributor Author

Enngage commented Sep 4, 2018

I'm pretty sure thats invalid and has no real purpose (other then maybe the max. string length in .NET?). I would recommend removing that from .NET SDK. For maximum chars in URL I checked mainly the answers from SO here https://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers)

@petrsvihlik
Copy link
Contributor

The other option would be to set it to the lowest value - 2k... But you are probably right it's not worth implementing as there is no standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants