Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netstandard2.0 as a target #110

Closed
petrsvihlik opened this issue May 15, 2018 · 0 comments
Closed

Add netstandard2.0 as a target #110

petrsvihlik opened this issue May 15, 2018 · 0 comments

Comments

@petrsvihlik
Copy link
Contributor

petrsvihlik commented May 15, 2018

Problem:
When installing the SDK, user can sometimes get this:
microsoftteams-image
There are too many package dependencies. We try to reduce the number of references to the necessary minimum.

The root cause is actually targeting netstandard1.3: https://stackoverflow.com/questions/47365136/why-does-my-net-standard-nuget-package-trigger-so-many-dependencies. In CM Helpers SDK we're using netstandard2.0 + net45 targets and there's no such issue.

Here's a recommendation from David Fowler:
https://twitter.com/davidfowl/status/1008453902058917888

I know we said target The lowest netstandard but we really want everyone to re-baseline at netstandard 2.0. At the very least add a netstandard 2.0 target.

Other services use the same approach as well.

Solution:

  • add netstandard2.0 target to reduce the dependency footprint of the SDK.

Additional steps we can take to reduce the dependency footprint are described in #117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants