Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WithCustomEndpoint tolerant for missing trailing slash #341

Open
JiriKovar opened this issue Jul 11, 2022 · 2 comments
Open

Make WithCustomEndpoint tolerant for missing trailing slash #341

JiriKovar opened this issue Jul 11, 2022 · 2 comments

Comments

@JiriKovar
Copy link
Contributor

Motivation

In the unit tests in DeliveryOptionsBuilderTests we don't use trailing slashed for custom endpoints, but without a trailing slash, the URL is constructed incorrectly. Which makes it confusing and the error messages are not great enough to explain what was wrong, so you need to debug the issue to figure out what is wrong, which is tedious.

Proposed solution

In our internal code, we are tolerant to missing trailing slashes when building a URL. We should provide the customers of our SDKs with the same luxury.

Additional context

I have personally misguided a customer in an intercom conversation to use the custom domain, because I took an example from the unit tests, then we spent some time sending messages back and forth to figure out what was wrong and this improvement would probably take less time then we have spent on it.

@MiroKentico
Copy link
Contributor

Hi @JiriKovar, thanks for the suggestion. We will take it as possible minor improvement.

@Simply007
Copy link
Contributor

Simply007 commented Jun 29, 2023

Related t #268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants