Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IOptionsSnapshot instead of IOptions #59

Closed
petrsvihlik opened this issue Jul 3, 2017 · 3 comments · Fixed by #188
Closed

Use IOptionsSnapshot instead of IOptions #59

petrsvihlik opened this issue Jul 3, 2017 · 3 comments · Fixed by #188
Assignees
@tomasjurasek
Labels
enhancement good first issue groomed The issue has been groomed and should be in a good shape. help wanted refactoring up-for-grabs
Milestone
13.0.0

Comments

@petrsvihlik
Copy link
Contributor

petrsvihlik commented Jul 3, 2017 •
edited

Prerequisity

#117

Motivation

Once an app is initialized, the configuration of the SDK is set in stone. To reload the configuration (for new instances of the DeliveryClient, for example), the app needs to be restarted.

Design guidelines

Use IOptionsSnapshot instead of IOptions to allow reloading of configuration.

Resources
@petrsvihlik petrsvihlik mentioned this issue Jul 3, 2017
Closed
@JanLenoch JanLenoch modified the milestone: Prioritization May 22, 2018
@JanLenoch JanLenoch added help wanted up-for-grabs good first issue groomed The issue has been groomed and should be in a good shape. blocked and removed question labels Aug 13, 2018
@kontent-ai kontent-ai deleted a comment from JanLenoch Aug 27, 2018
@petrsvihlik petrsvihlik added this to In progress in .NET Community Backlog Feb 19, 2020
@petrsvihlik petrsvihlik added this to the vNext milestone Feb 19, 2020
@petrsvihlik
Copy link
Contributor Author

or IOptionsMonitor ;)

@petrsvihlik petrsvihlik linked a pull request Feb 19, 2020 that will close this issue
Delivery client factory #188
Merged
5 tasks
@petrsvihlik
Copy link
Contributor Author

this is done in #188

.NET Community Backlog automation moved this from In progress to Done Mar 16, 2020
@petrsvihlik
Copy link
Contributor Author

https://www.nuget.org/packages/Kentico.Kontent.Delivery/13.0.1-beta9 and on

@pokornyd pokornyd removed this from Done in .NET Community Backlog Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasjurasek tomasjurasek

Labels
enhancement good first issue groomed The issue has been groomed and should be in a good shape. help wanted refactoring up-for-grabs
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

Delivery client factory
3 participants
@tomasjurasek @petrsvihlik @JanLenoch