Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get codenames of modular (linked) items in a newer way #8

Closed
JanLenoch opened this issue Oct 10, 2018 · 2 comments
Closed

Get codenames of modular (linked) items in a newer way #8

JanLenoch opened this issue Oct 10, 2018 · 2 comments
Labels
blocked enhancement New feature or request good first issue Good for newcomers groomed hacktoberfest help wanted Extra attention is needed up-for-grabs

Comments

@JanLenoch
Copy link
Contributor

JanLenoch commented Oct 10, 2018 •
edited
Loading

Blocked: We should first decide if using debug is better or not in #12

Motivation

Up until now, the JS SDK was stripping the modular_content array of codenames of content items from the response. It is no longer the case.

Proposed solution

Remove the normalize.refillRichTextModularCodenames method in favor of using the new linkedItemCodenames property of rich text element objects.
@JanLenoch JanLenoch added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers groomed hacktoberfest up-for-grabs labels Oct 10, 2018
@JanLenoch JanLenoch changed the title Get codenames of modular (linked) items in a newest way Get codenames of modular (linked) items in a newer way Oct 10, 2018
@JanLenoch

This comment has been minimized.

Sign in to view
@JanLenoch JanLenoch added this to Priority in Prioritization via automation Oct 24, 2018
@JanLenoch
Copy link
Contributor Author

Fixed via e1dfc74

@JanLenoch JanLenoch removed this from Priority in Prioritization Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked enhancement New feature or request good first issue Good for newcomers groomed hacktoberfest help wanted Extra attention is needed up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JanLenoch