Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance on interface ipmitool? #105

Closed
EmilioPeJu opened this issue Oct 6, 2021 · 4 comments
Closed

Improve performance on interface ipmitool? #105

EmilioPeJu opened this issue Oct 6, 2021 · 4 comments

Comments

@EmilioPeJu
Copy link
Contributor

EmilioPeJu commented Oct 6, 2021

This is more a question than an issue. Currently, the ipmitool interface is based on executing ipmitool on every request, however, creating a new process is costly. The question is: is it worth changing it to run 'ipmitool shell' from start and send the request to that process (instead of creating a new processes every time)? The downside is that we might need to keep 4 processes running (one for each possible lun value), but that shouldn't be a problem.

@hthiery
Copy link
Contributor

hthiery commented Oct 6, 2021

As background: we had this backend as a quick way to test our IPMI implementation. Performance optimization was not a requirement for us. If we have a backend that works the way you suggest, that could certainly be an improvement. I don't mind including a new interface (e.g. ipmitool-shell). So if it is important for you feel free to make a PR.

@EmilioPeJu
Copy link
Contributor Author

EmilioPeJu commented Oct 6, 2021

Thanks for the information, I didn't know it was focused on testing, I'll try other interfaces to see how that affects performance.
I'm closing this as it is not so important. Though any performance improvement would be nice, currently my polling loop takes around 4 seconds to get all the sensor's values in a test mTCA crate.

@hthiery
Copy link
Contributor

hthiery commented Oct 6, 2021

what interface connection do you use? is it plain rmcp? than you could try the native rmcp implemenation in this lib

@EmilioPeJu
Copy link
Contributor Author

Yes, it is, I'll give it a try, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants