Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React peer dependencies on react-konva and react-konva-utils #8

Closed
andres-palumbo opened this issue Sep 4, 2021 · 2 comments
Closed

Comments

@andres-palumbo
Copy link

First of all, thank you for such an amazing library!

I'm seeing that this library has a different React peer dependency version than react-konva:

react-konva-utils:

"react": "^17.0.2",
"react-dom": "^17.0.2"

react-konva:

"react": ">=16.8.0",
"react-dom": ">=16.8.0"
@lavrton
Copy link
Member

lavrton commented Sep 6, 2021

Is it an issue for you?

@andres-palumbo
Copy link
Author

We can work around the issue but basically, if you want to use react-konva + react-konva-utils with react: 16.14.0 you will get a peerDependency error.

(using npm 7)

npm ERR! Found: react@16.14.0
npm ERR! node_modules/react
npm ERR!   react@"16.14.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^17.0.2" from react-konva-utils@0.2.0
npm ERR! node_modules/react-konva-utils
npm ERR!   react-konva-utils@"^0.2.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@lavrton lavrton closed this as completed Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants