New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out how we want to specify images for upstream/vs. downstream #60
Comments
This issue is currently awaiting triage. |
If we're going to be following a similar pattern to previous RHMT products, please consider using Reference(s):
It's not significant for downstream short of letting OSBS due automatically for |
Thanks for the heads up @rayfordj We should update to follow this pattern since it will save a lot of pain down the line. cc @djzager @JaydipGabani |
/triage accepted |
/kind feature |
This issue synced with: https://issues.redhat.com/browse/MTRHO-117 |
We are likely going to need to replace upstream images with downstream images, so we'll need to decide how we want to do so and implement it. For the most part this can be as simple as specifying them using env vars on the operator deployment. These can then be updated in an automated fashion during the downstream buils.
See for instance on mig-operator:
https://github.com/konveyor/mig-operator/blob/master/deploy/olm-catalog/bundle/manifests/crane-operator.v99.0.0.clusterserviceversion.yaml#L681-L732
In some cases the deployments using the containers aren't directly launched by the operator (rsync-transfer as a for instance). In these cases we have to think about how we want to pass these in.
I believe crane-runner is also hard coded in a bunch of cluster tasks so we'll have to fix that as well.
The text was updated successfully, but these errors were encountered: