Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how we want to specify images for upstream/vs. downstream #60

Closed
jmontleon opened this issue Jul 18, 2022 · 6 comments · Fixed by #61
Closed

Figure out how we want to specify images for upstream/vs. downstream #60

jmontleon opened this issue Jul 18, 2022 · 6 comments · Fixed by #61
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jmontleon
Copy link
Contributor

We are likely going to need to replace upstream images with downstream images, so we'll need to decide how we want to do so and implement it. For the most part this can be as simple as specifying them using env vars on the operator deployment. These can then be updated in an automated fashion during the downstream buils.

See for instance on mig-operator:
https://github.com/konveyor/mig-operator/blob/master/deploy/olm-catalog/bundle/manifests/crane-operator.v99.0.0.clusterserviceversion.yaml#L681-L732

In some cases the deployments using the containers aren't directly launched by the operator (rsync-transfer as a for instance). In these cases we have to think about how we want to pass these in.

I believe crane-runner is also hard coded in a bunch of cluster tasks so we'll have to fix that as well.

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 18, 2022
@github-actions
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

@rayfordj
Copy link

rayfordj commented Jul 18, 2022

If we're going to be following a similar pattern to previous RHMT products, please consider using RELATED_IMAGE_ prefix from the onset. It will allow us to leverage OSBS's automation and we may then abandon managing image digest collection & injection (manually, via scripts) into downstream CSV for relatedImages.

Reference(s):

It's not significant for downstream short of letting OSBS due automatically for relatedImages: what we're doing manually (scripted) today. I imagine any reduction in code/script maintenance effort may be a benefit. 🤷‍♂️

@jmontleon
Copy link
Contributor Author

Thanks for the heads up @rayfordj

We should update to follow this pattern since it will save a lot of pain down the line. cc @djzager @JaydipGabani

@eriknelson
Copy link
Contributor

/triage accepted
/priority normal

@openshift-ci openshift-ci bot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. labels Jul 19, 2022
@github-actions github-actions bot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jul 19, 2022
@eriknelson
Copy link
Contributor

/kind feature

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 19, 2022
@github-actions
Copy link

This issue synced with: https://issues.redhat.com/browse/MTRHO-117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
3 participants