Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to use a custom pvc transfer image for source and destination #57

Open
jmontleon opened this issue Jul 18, 2022 · 3 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jmontleon
Copy link
Contributor

For downstream we will likely need to use allow using a different rsync-transfer image. Even with a community release it will be necessary in disconnected or restricted networks. We'll need to update the pvc-transfer ClusterTask to accept these options.

Once those PRs are merged and we've decided how to pass them in we should update the ClusterTask to deal with them properly.

Based on current PRs it should look roughly like so:

crane transfer-pvc \
          --source-image=quay.io/jmontleon/rsync-source-transfer:latest \
          --destination-image=quay.io/jmontleon/rsync-transfer:latest \
...
@jmontleon jmontleon added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 18, 2022
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 18, 2022
@github-actions
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

@eriknelson
Copy link
Contributor

/triage accepted
/priority normal

@openshift-ci openshift-ci bot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. labels Jul 19, 2022
@github-actions github-actions bot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jul 19, 2022
@github-actions
Copy link

This issue synced with: https://issues.redhat.com/browse/MTRHO-116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants