Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PF CodeEditor with newly available YAML editor in plugin SDK #103

Open
mturley opened this issue Jul 14, 2022 · 2 comments
Open
Labels
blocked needs-kind needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mturley
Copy link
Contributor

mturley commented Jul 14, 2022

There are some issues with syntax highlighting and other styles with the PF CodeEditor we're using due to stylesheets conflicting with the ones for the console's built in editor. Now that that editor is available in the plugin SDK we should switch to it.

Edit: Not sure if this is going to work. The ResourceYAMLEditor exposed by the SDK is intended for editing an existing resource, not editing unsaved YAML before creating a resource. It has save/cancel/reload buttons that don't make sense here and if you click Cancel it will weirdly redirect you to the project resource page. There seems to be no way to disable that behavior and render only the editor itself. This will either be a WONTFIX or we need to enhance the editor in the SDK, and either way it's not going to make Tech Preview.

Edit 2: There's a new development here, we may be getting the plain YAMLEditor in a future SDK version. Discussion here: https://coreos.slack.com/archives/C011BL0FEKZ/p1658168646396789

@github-actions
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

@github-actions github-actions bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind needs-priority labels Jul 14, 2022
@mturley mturley added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 14, 2022
@github-actions
Copy link

This issue synced with: https://issues.redhat.com/browse/MTRHO-99

@mturley mturley assigned mturley and unassigned mturley Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked needs-kind needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

1 participant