Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the project switcher bar at the top of the management page and wizard, handle all-projects state properly #106

Open
mturley opened this issue Jul 14, 2022 · 3 comments
Labels
blocked needs-kind needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mturley
Copy link
Contributor

mturley commented Jul 14, 2022

See early attempt at this that was closed: #66

By changing the URL prefix to /k8s/ns/:namespace/* the console automatically shows this project switcher at the top of the page. However, when doing this, if the user selects "All projects" in the bar the UI ends up on a 404 page. We can likely work around this by handling that all-namespaces route, but there is a bug in the console that prevents this (BZ coming soon for that, will edit it in here).

161318810-66093b91-aef7-4fe0-b75e-a365a9efe997

However, the URL prefix change is possibly not the best way of implementing this. Comparing to the Add page and Pipelines page, we see they do this without using /k8s in their URL (which is intended for pages representing individual k8s resources) by using components that are not currently exposed by the plugin SDK, CreateProjectListPage and NamespacedPage. I attempted a PR to add these to the SDK but it needs reevaluation: openshift/console#11823

Also, currently when you reach the management page without a project selected, you reach a stub page that just directs you to the Projects page where you can select and create a project, then you have to navigate back to our management page. Using CreateProjectListPage to handle the "all projects" state is a better solution.

@github-actions
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

@github-actions github-actions bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind needs-priority labels Jul 14, 2022
@mturley mturley added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 14, 2022
@github-actions
Copy link

This issue synced with: https://issues.redhat.com/browse/MTRHO-104

@eriknelson
Copy link

Unlikely this is something we'll be able to do until a future version of OCP, see discussion: https://coreos.slack.com/archives/C011BL0FEKZ/p1657814298016319?thread_ts=1656351896.551959&cid=C011BL0FEKZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked needs-kind needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants