Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement localization or remove the react-i18next dependency #109

Open
mturley opened this issue Jul 14, 2022 · 2 comments
Open

Implement localization or remove the react-i18next dependency #109

mturley opened this issue Jul 14, 2022 · 2 comments
Labels
needs-kind needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mturley
Copy link
Contributor

mturley commented Jul 14, 2022

The dynamic plugin guidelines state that we should use react-i18next for localization, and the template repo we started with already had it installed. We currently still have it as a dependency but we are not using it (all text is just hard-coded in English).

We need to decide whether we will actually be doing localization. If so, we need to determine a process for that and implement it, and if not we should remove this dependency.
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 14, 2022
@github-actions
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

@mturley mturley added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 14, 2022
@github-actions
Copy link

This issue synced with: https://issues.redhat.com/browse/MTRHO-106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-kind needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mturley