Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Application Imports" management page - refresh credentials feature #97

Open
mturley opened this issue Jul 12, 2022 · 3 comments
Open
Assignees
Labels
needs-kind needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mturley
Copy link
Contributor

mturley commented Jul 12, 2022

On the management page being introduced in #88, there is an additional feature we've mentioned in meetings that I want to capture: a button somewhere (action in the kebab menu?) for letting the user refresh the oauth tokens stored in the secrets associated with the pipelines.

If the user created the pipelines some time ago, their tokens are likely to have expired. There should be an easy way to refresh them without having to create new pipelines or manually edit secrets. This includes (a) pasting in a new oauth token for the source cluster and (b) triggering a patch via crane-secret-service that will automatically refresh the oauth token for the target/host cluster. Not sure if these should be separate functions or always be done together.

Another idea @vconzola mentioned was that when the user clicks the Stage or Cutover buttons, the UI could first run a check via crane-reverse-proxy to see if the source cluster's token is still valid (and maybe also somehow check the host cluster's token) and prompt the user to refresh it before running the pipelines. We could also possibly just automatically refresh the host oauth token via crane-secret-service immediately before starting any pipelinerun, although that might be too much magic.

@github-actions
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

@github-actions github-actions bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind needs-priority labels Jul 12, 2022
@mturley
Copy link
Contributor Author

mturley commented Jul 12, 2022

/triage accepted

@openshift-ci openshift-ci bot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 12, 2022
@github-actions github-actions bot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 12, 2022
@github-actions
Copy link

This issue synced with: https://issues.redhat.com/browse/MTRHO-93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant