[BUG] transform trying to transform failures

[jmontleon]

After running in dev sandbox I have failures like these:

$ cat failures/rhn-engineering-jmontleo-dev/backups.yaml 
APIResource:
  kind: Backup
  name: backups
  namespaced: true
  singularName: backup
  storageVersionHash: eSTCs+S6z7U=
  verbs:
  - delete
  - deletecollection
  - get
  - list
  - patch
  - create
  - update
  - watch
error:
  ErrStatus:
    apiVersion: v1
    code: 403
    details:
      group: velero.io
      kind: backups
    kind: Status
    message: 'backups.velero.io is forbidden: User "rhn-engineering-jmontleo" cannot
      list resource "backups" in API group "velero.io" in the namespace "rhn-engineering-jmontleo-dev"'
    metadata: {}
    reason: Forbidden
    status: Failure

I would not consider these unexpected.

But then transform fails trying to transform them...

+ /usr/bin/crane transform --ignored-patches-dir= --flags-file= --export-dir=/var/crane/export --transform-dir=/var/crane/transform
Error: Object 'Kind' is missing in '{"APIResource":{"kind":"Backup","name":"backups","namespaced":true,"singularName":"backup","storageVersionHash":"eSTCs+S6z7U=","verbs":["delete","deletecollection","get","list","patch","create","update","watch"]},"error":{"ErrStatus":{"apiVersion":"v1","code":403,"details":{"group":"velero.io","kind":"backups"},"kind":"Status","message":"backups.velero.io is forbidden: User \"rhn-engineering-jmontleo\" cannot list resource \"backups\" in API group \"velero.io\" in the namespace \"rhn-engineering-jmontleo-dev\"","metadata":{},"reason":"Forbidden","status":"Failure"}}}'
Usage:
  crane transform [flags]
  crane transform [command]

[sseago]

Ahh. Yeah, it looks like transform is just recursively traversing ExportDir It should be starting with ExportDir + "/resources" instead

[sseago]

As a workaround, you could append "/resources" on the CLI until there's a fix.

[sseago]

although that workaround would make export and transform inconsistent, because you would not want to add "/resources" on export itself. It's possible that we have a similar bug with apply.

[sseago]

Upon further discussion in slack, transform and apply need to cope with a passed-in export-dir which has the resources and failures subdirs (as created by crane export) and ignoring the failures dir and with a passed-in export-dir which points directly to the resources (which would happen if the user used some other means of yaml creation).

[eriknelson]

/priority normal
/triage accepted

[github-actions]

This issue synced with: https://issues.redhat.com/browse/MTRHO-68

[jmontleon]

It looks like this is fixed: #76 and I did not encounter it again working in DevSandbox