Bug 2000243: Move PV conflict validation to MigMigration from MigPlan #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
force-pushed
the
validationFix
branch
2 times, most recently
from
df44ea3
to
08f7126
Compare
pranavgaikwad
changed the title
pranavgaikwad
force-pushed
the
validationFix
branch
from
08f7126
to
8bc6295
Compare
|
Bug 2000243 does not have a target release set |
|
Bug 2000243 does not have a target release set |
1 similar comment
|
Bug 2000243 does not have a target release set |
sseago
approved these changes
Sep 1, 2021
|
Valid bug 2000243 |
pranavgaikwad
added a commit
to pranavgaikwad/mig-controller
that referenced
this pull request
Sep 1, 2021
pranavgaikwad
added a commit
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demotes the category of error in MigPlan validation of conflicting PVC names from Critical to Warn. This ensures that the users can still create the Migration Plan using the Wizard and later go ahead and map the PVCs to correct the wrong mapping. The Critical failing validation is moved to MigMigration instead. It ensures that before running a state migration, PVC mappings are verified for presence of any name conflicts. The migration will be failed if a conflict exists and the users will need to correct the mappings before retrying migration. Updating to trigger automation...