separate cred secrets for azure/gcp/aws #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Required mig-operator PR: migtools/mig-operator#166 |
jortel
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
LGTM
One thing though: By convention the term CloudSecret in the codebase refers to the cloud secret used by velero. So the velero is implied. The new methods and constants added include Velero. To be consistent, we should either remove Velero from the new names or add Velero all of the other names in the codebase.
sseago
force-pushed
the
provider-cloud-credentials
branch
from
ef897ef
to
bca0376
Compare
dymurray
approved these changes
Dec 2, 2019
jortel
pushed a commit
that referenced
this pull request
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for aws, gcp, and azure cred secrets to coexist on the same velero instance. Only one set of credentials per provider is still a limitation, but this allows the use of multiple providers at once for a given controller instance.
This PR requires a (forthcoming) mig-operator PR for azure/gcp use, since without it velero won't look in the right location for (or mount) those provider secrets.