New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1831711: Fix incompatible GVK detection for 4.3->4.4 migrations #530
Conversation
Can one of the admins verify this patch? |
Logging the initial PR comment for history
|
\test |
✔️ Setup e2e environment |
This PR narrows the GVK diff list so that migrations 4.3 -> 4.4 can run. In a followup PR we plan to only notify the user of a GVK diff if the GVK diff is present in a namespace selected for migration. |
This patch fixes https://bugzilla.redhat.com/show_bug.cgi?id=1831711.
The controller now uses
ServerPreferredNamespacedResources
tolist the preferred namespaced resources on source cluster and then
compare the group version with destination cluster. It adds two unit
tests to verify. As further steps, more extensive unit test needs to
be added to understand this better