Bug 1822127 - Create secret with proxy config if setting present #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmontleon
approved these changes
Apr 7, 2020
|
NOTE: This PR is safe to merge independent of the associated controller change, but it's intended to work in conjunction with migtools/mig-controller#482 |
eriknelson
force-pushed
the
proxy-secret
branch
2 times, most recently
from
842a66d
to
ff6775d
Compare
jmontleon
approved these changes
Apr 8, 2020
* generateName is a headache with the k8s module since its trying to patch a resource
eriknelson
changed the title
jmontleon
approved these changes
Apr 8, 2020
eriknelson
added a commit
that referenced
this pull request
Apr 9, 2020
* Create secret with proxy config if setting present * Add label to proxy secret and gen name * Quote label true value * Revert to using static name * generateName is a headache with the k8s module since its trying to patch a resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each of the following check the box when you have verified either:
Affected versions:
The CSV is responsible in OLM installs for
The operator.yml is responsible in non-OLM installs for
The ansible role is responsible in non-OLM installs for:
The ansible role is always responsible for:
Not applicable
If this PR updates a release or replaces channel
deploy/olm-catalog/konveyor-operatorkonveyor-operator.package.yamldeploy/non-olmdeploy/non-olm.github/pull_request_template.mdAffected versions list