Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template out validations on old OCP 3.x releases #328

Merged
merged 1 commit into from May 5, 2020

Conversation

jmontleon
Copy link
Collaborator

For each of the following check the box when you have verified either:

  • the changes have been made for each applicable version
  • no changes are required for the item
  • PR's that are submitted without running through the list below will be CLOSED

Affected versions:

  • Latest
  • 1.1
  • 1.0

The CSV is responsible in OLM installs for

  • Operator permissions
  • Operator deployment
  • Operand permissions
  • CRDs

The operator.yml is responsible in non-OLM installs for

  • Operator permissions
  • Operator deployment

The ansible role is responsible in non-OLM installs for:

  • Operand permissions
  • CRDs

The ansible role is always responsible for:

  • Operand deployment

If this PR updates a release or replaces channel

  • I created a new z release directory in deploy/olm-catalog/konveyor-operator
  • I updated channels in the konveyor-operator.package.yaml
  • I created a new release directory in deploy/non-olm
  • I created or updated the major.minor link in deploy/non-olm
  • Updated the .github/pull_request_template.md Affected versions list

Copy link
Contributor

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Worth noting that when Kube 2.0 releases this won't work necessarily but its good for now.

@@ -15,6 +15,7 @@ spec:
singular: backup
preserveUnknownFields: false
scope: Namespaced
{% if lookup('k8s', cluster_info='version').kubernetes.minor|replace('+', '')|int < 11 %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be comparing the major version too? This will break with kubernetes 2.0

@jmontleon jmontleon merged commit a5b60fd into migtools:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants