Bug 1981810: include events.events.k8s.io in resource excludes #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apinnick
reviewed
Aug 23, 2021
| @@ -32,6 +32,7 @@ service catalog resources or OLM resources, OLM migration is not handled by Cran | |||
| - serviceplans | |||
| - operatorgroups | |||
| - events | |||
| - events.events.k8s.io | |||
There was a problem hiding this comment.
Does this need to be documented in downstream docs?
There was a problem hiding this comment.
@apinnick Ahh, good question. If downstream docs include the same content here -- i.e. listing the default set of excluded resources -- then probably yes. Here is the full list (with the last in the list being the new one just added):
- imagetags
- templateinstances
- clusterserviceversions
- packagemanifests
- subscriptions
- servicebrokers
- servicebindings
- serviceclasses
- serviceinstances
- serviceplans
- operatorgroups
- events
- events.events.k8s.io
There was a problem hiding this comment.
Yes, it looks like downstream docs includes the full list:
excluded_resources:
- imagetags
- templateinstances
- clusterserviceversions
- packagemanifests
- subscriptions
- servicebrokers
- servicebindings
- serviceclasses
- serviceinstances
- serviceplans
- operatorgroups
- events
I'll create a bug to add the new resource.
rayfordj
changed the title
|
Valid bug 1981810 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check each of the following when appropriate to help reviewers verify work is complete.
Modifying an existing version
Adding a new release version
deploy/olm-catalog/crane-operatorcrane-operator.package.yamldeploy/non-olmdeploy/non-olm