Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvements to the Add/Edit Cluster and Storage forms #663

Closed
eriknelson opened this issue Feb 11, 2020 · 9 comments · Fixed by #846
Closed

UX improvements to the Add/Edit Cluster and Storage forms #663

eriknelson opened this issue Feb 11, 2020 · 9 comments · Fixed by #846
Assignees
Labels
look-and-feel Designates work limited to presentation layer changes release-1.2.0 Required issue for 1.2 release UXD Work requireing UX design attention
Projects
Milestone

Comments

@eriknelson
Copy link
Contributor

eriknelson commented Feb 11, 2020

After our call with @vconzola and @mansam regarding custom CA bundle support, we decided to accept those PRs as they are since they encapsulate the functionality desired for the feature, and to separately address the UX improvements that Vince raised during the call so the two PRs are not conflated with one another. I'm filing this as a placeholder issue for now because I'd like to circle back with screenshots from master so we can itemize the UX changes required and get those fixed. As of now, I'm aware of:

  • We need to ensure the correct buttons are marked as primary/secondary buttons, right now they are all primary.
  • The "Is azure cluster prompt" should be above the URL, but below the name field.
  • The close button should be a cancel button, as seen in the following mock provided by vince:

1

1-1

@eriknelson eriknelson added UXD Work requireing UX design attention release-1.2.0 Required issue for 1.2 release look-and-feel Designates work limited to presentation layer changes labels Feb 11, 2020
@eriknelson eriknelson added this to the Release 1.2 milestone Feb 12, 2020
@mturley mturley self-assigned this Feb 13, 2020
@mturley
Copy link
Collaborator

mturley commented Feb 13, 2020

Related to #356, discussing with @vconzola right now. I may fix this in the same PR.

@eriknelson
Copy link
Contributor Author

eriknelson commented Feb 13, 2020

@mturley be aware we intend to bring in Sam's CA bundle functional changes to master prior to making these changes. You may want to implement this on top of his PR's commits. @ibolton336 is in the process of reviewing and testing @mansam's PRs.

@mturley
Copy link
Collaborator

mturley commented Feb 13, 2020

Gotcha, thanks for the heads up @eriknelson

@vconzola
Copy link
Collaborator

Might also want to add a popover for SSL required field as part of this.

@mturley
Copy link
Collaborator

mturley commented Mar 11, 2020

Note to self: we should replace react-select with PatternFly's Select in the Storage form as part of this issue. Other occurrences of react-select are covered by #736, #585, #586 and #587.

@eriknelson eriknelson changed the title [PLACEHOLDER] UX improvements to the Add/Edit Cluster and Storage forms UX improvements to the Add/Edit Cluster and Storage forms Mar 30, 2020
@eriknelson eriknelson added this to To do in Sprint 182 Mar 31, 2020
@mturley
Copy link
Collaborator

mturley commented Mar 31, 2020

The CA bundle file field here in the cluster form should also be converted to a PF FileUpload component as part of this issue.

@vconzola , this is lower priority, but you suggested a popover on the "Require SSL verification" field here. Do you know what text that should have?

@vconzola
Copy link
Collaborator

@mansam @eriknelson Can you provide some text explaining when a user would select the "Require SSL verification" checkbox?

@mturley
Copy link
Collaborator

mturley commented Apr 17, 2020

When you guys get a chance to figure out the text for the "Require SSL verification" help info, I plan to get this done asap.

@eriknelson
Copy link
Contributor Author

Hint text:

"[Cluster]
"Select 'Require SSL verification' to verify SSL connections to the cluster.
If you are using a self-signed certificate, you may either disable SSL
verification, or upload your certificate bundle."

[Replication Repository]
"Select 'Require SSL verification' to verify SSL connections to the object store.
If you are using a self-signed certificate, you may either disable SSL
verification, or upload your certificate bundle."

Spoke with @vconzola and we want this as inline hint text instead of behind a tooltip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
look-and-feel Designates work limited to presentation layer changes release-1.2.0 Required issue for 1.2 release UXD Work requireing UX design attention
Projects
No open projects
Sprint 182
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants