Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1996902: select bug fix #1282

Merged
merged 8 commits into from Aug 25, 2021
Merged

Bug 1996902: select bug fix #1282

merged 8 commits into from Aug 25, 2021

Conversation

ibolton336
Copy link
Contributor

@ibolton336 ibolton336 commented Aug 23, 2021 •
edited

@ibolton336
Copy link
Contributor Author

ibolton336 commented Aug 23, 2021 •
edited

After fix:

Screen.Recording.2021-08-23.at.7.24.23.PM.mov

Previously, when all items in the table were selected, deselecting a single item would leave the select all checkbox still checked. This fixes this within the namespaces table and the PVs table

@ibolton336
Copy link
Contributor Author

@vconzola Does this look ok to you?

@ibolton336
Copy link
Contributor Author

Before fix:

Screen.Recording.2021-08-23.at.7.27.49.PM.mov

@ibolton336 ibolton336 marked this pull request as ready for review August 23, 2021 23:35
@ibolton336 ibolton336 requested a review from a team August 23, 2021 23:35
@ibolton336 ibolton336 changed the title Bug xxxxxxx: select bug fix Bug 1996902: select bug fix Aug 23, 2021
@github-actions
Copy link

Bug was not moved to POST but was valid. Something went wrong

@github-actions
Copy link

Valid bug 1996902

vconzola
vconzola requested changes Aug 24, 2021
View reviewed changes
Copy link
Collaborator

@vconzola vconzola left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibolton336 You should use the PatternFly bulk selector component in the table toolbar. This should handle checkbox state (and give a selection count) for you.

@ibolton336
Copy link
Contributor Author

ibolton336 commented Aug 25, 2021 •
edited

@ibolton336 You should use the PatternFly bulk selector component in the table toolbar. This should handle checkbox state (and give a selection count) for you.

@vconzola I have opened an issue capturing the work to integrate the bulk selector. #1289 With that said, I think it would be best to fix this bug in the short term.

@ibolton336 ibolton336 merged commit 04f1cf7 into migtools:master Aug 25, 2021
@ibolton336 ibolton336 deleted the fix-select-all branch August 25, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vconzola vconzola vconzola requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibolton336 @vconzola